From patchwork Fri Oct 29 11:59:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanlin Chen X-Patchwork-Id: 14418 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E5C0DBDB1C for ; Fri, 29 Oct 2021 12:00:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A7403600BF; Fri, 29 Oct 2021 14:00:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mORXNa/D"; dkim-atps=neutral Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A6FD600B8 for ; Fri, 29 Oct 2021 14:00:09 +0200 (CEST) Received: by mail-pg1-x52c.google.com with SMTP id j9so1543267pgh.1 for ; Fri, 29 Oct 2021 05:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tR9zsB15kCVtnpZ46suSVvmTtEQhG1D1AqAr7QKKInw=; b=mORXNa/DrBx60QPYtycNOWjs6W9c+t9QJayhB6FQgv109VAcp3RCjXXaq05IGkbIQC nCckyX/lREnWuZI+EUEBmawL+9NEHd/tSiyuHvZK7BzSCuShbHy3AedoQz0oKsgDHOp9 SbCsYdPuxQuwY5aXTa74oi/YCafPO9tl2NllY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tR9zsB15kCVtnpZ46suSVvmTtEQhG1D1AqAr7QKKInw=; b=XQ33bYaVB2BmOFUr+CFG9x9VKE+1fmgwrzWJoNt1Y4jwbXth5zZcNJcA2ulSaICdvj kktihtBt8rKCJaIUmo0rXIDut6YHgnGRhjBv40sYnONtQxxPs83IN6tQH/kFIhSAvAhh RNEjbGMtDFM4loM0LP0JHQMgCOpToLqFWXPWRy89fdUxACBq+DcLcDE+aeg10m8YBUuu vPJAIGALESSbfe7YxtwuHbtnntWH3KNyLUIbDG1g05QAgtqWBpR3/t/0Kw1VI2CJj24d wbJp9FcR0E+3qCfYgNJ1ew6/U7GLbQW9PNu/vV4FS2FLFUyM2nfvndYx1G52YWOnQJrt PmBA== X-Gm-Message-State: AOAM530Q4bNAMPjKr1CcHglLBoIeDd9W6VUp6Vg2cixQqXJNKa9MhdK5 eJZLwP86DkgEHFHtNTGz5bQW5nDv+fV3vovz X-Google-Smtp-Source: ABdhPJwAtpqTFc/Pl7w6Ca+/i6M99yTY2JQRWdo11JggqePFODD5+qFQNfyA46vcOgtekXGF/tVSNA== X-Received: by 2002:a63:9554:: with SMTP id t20mr7760818pgn.255.1635508804735; Fri, 29 Oct 2021 05:00:04 -0700 (PDT) Received: from localhost ([2401:fa00:1:10:35fe:d53b:684:b538]) by smtp.gmail.com with UTF8SMTPSA id n9sm11587805pjk.3.2021.10.29.05.00.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 05:00:04 -0700 (PDT) From: Han-Lin Chen To: libcamera-devel@lists.libcamera.org Date: Fri, 29 Oct 2021 19:59:56 +0800 Message-Id: <20211029120001.2469018-1-hanlinchen@chromium.org> X-Mailer: git-send-email 2.33.1.1089.g2158813163f-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The frame use mode is set according to Android Capture Intent in Intel HAL's implememtation. The current default mode ia_aiq_frame_use_still is only used with the single capture request. For preview use case, it has hard time converging AE and AF smoothly. Change the default mode to ia_aiq_frame_use_preview for better user experience. Signed-off-by: Han-Lin Chen Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- aiq/aiq_input_parameters.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp index 36e2b07..bc87b31 100644 --- a/aiq/aiq_input_parameters.cpp +++ b/aiq/aiq_input_parameters.cpp @@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults() { /*Ae Params */ aeInputParams.num_exposures = NUM_EXPOSURES; - aeInputParams.frame_use = ia_aiq_frame_use_still; + aeInputParams.frame_use = ia_aiq_frame_use_preview; aeInputParams.flash_mode = ia_aiq_flash_mode_off; aeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic; aeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative; @@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults() aeInputParams.manual_convergence_time = -1; /* AWB Params */ - awbParams.frame_use = ia_aiq_frame_use_still; + awbParams.frame_use = ia_aiq_frame_use_preview; awbParams.scene_mode = ia_aiq_awb_operation_mode_auto; awbParams.manual_convergence_time = -1.0; awbParams.manual_cct_range = nullptr; @@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults() /* AF Params */ afParams = { - ia_aiq_frame_use_still, 0, 1500, + ia_aiq_frame_use_preview, 0, 1500, ia_aiq_af_operation_mode_auto, ia_aiq_af_range_normal, ia_aiq_af_metering_mode_auto, @@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults() /* GBCE Params */ gbceParams.gbce_level = ia_aiq_gbce_level_bypass; gbceParams.tone_map_level = ia_aiq_tone_map_level_default; - gbceParams.frame_use = ia_aiq_frame_use_still; + gbceParams.frame_use = ia_aiq_frame_use_preview; gbceParams.ev_shift = 0; /* SA Params */ - saParams.frame_use = ia_aiq_frame_use_still; + saParams.frame_use = ia_aiq_frame_use_preview; } } /* namespace ipa::ipu3::aiq */