From patchwork Thu Oct 28 10:03:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanlin Chen X-Patchwork-Id: 14390 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 935F5BF415 for ; Thu, 28 Oct 2021 10:03:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 50E5C600BB; Thu, 28 Oct 2021 12:03:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="EfnqQy5Y"; dkim-atps=neutral Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CBA0600B5 for ; Thu, 28 Oct 2021 12:03:53 +0200 (CEST) Received: by mail-pg1-x52f.google.com with SMTP id t7so5876713pgl.9 for ; Thu, 28 Oct 2021 03:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DgneWOyX29bUTgvuPCS53eREeOsak0Fruu65Vcrdp8M=; b=EfnqQy5YPCV0LJaZqy389jrq/UkhxSOsA1Bk2s6IapLphcVMbjryY2s0dWVzR+zY5m AJbhGxfqt2EuwTwT2Qryf42ebIuSY7jDH+TknGphWAGVIvKkkvMYPpwB/vn1DJFM67M+ /O45KTB9yss25HVZRk9Wf53N+vYGXxR2k2FCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DgneWOyX29bUTgvuPCS53eREeOsak0Fruu65Vcrdp8M=; b=qekInM5Pkrfk7zoccAhtNo6RWvrD9EWV1oQ1WfNmrd3xGE4ZMNcTf5M10w5v3X4Yca GixvSfQIT3zBfBOZfGIRsrHUFDfo2y+WKS9A1MlPzvVyjzv4SccID5//1oPE/KwIwG6m refRg1mrMy3pNNnGedgoj42o2fp3jKQmi64+LnXTSoMj3bFV59YNrL2KpFpqoEKW7/rP IjR4kx4G90bMdMgR7wEh4KwJ6NGR5uaAWdwqNIApKiCIvaP7II2SdlDyuPPULCZUPjwy 1Ye0QMv2CZJtBbiktX+LUBcYn7U5TPdCTIVhRpu/kIDEfjPYeQZZ7CqqXMtJhW1wyBT8 1M0A== X-Gm-Message-State: AOAM532D7g9m4zrwnBmls0VbwFtqSazItVg7CzWboV/3MwCdrjgeFPee Ac+9qwMevjvKJcgS6dywGtxMmK8oVV5LtNAt X-Google-Smtp-Source: ABdhPJz3+Sdcjc2mr+uocmynwLxEZb/Nxnh+AT7KjCWyp89G6QSRFS5BASQa5zaR896xiK23sdE8MA== X-Received: by 2002:a65:62c1:: with SMTP id m1mr2455093pgv.339.1635415431962; Thu, 28 Oct 2021 03:03:51 -0700 (PDT) Received: from localhost ([2401:fa00:1:10:1bc:52e7:6df5:c7cf]) by smtp.gmail.com with UTF8SMTPSA id w21sm3122629pfu.68.2021.10.28.03.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 03:03:51 -0700 (PDT) From: Han-Lin Chen To: libcamera-devel@lists.libcamera.org Date: Thu, 28 Oct 2021 18:03:44 +0800 Message-Id: <20211028100349.1098545-1-hanlinchen@chromium.org> X-Mailer: git-send-email 2.33.1.1089.g2158813163f-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Han-Lin Chen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The frame use mode is set according to Android Capture Intent in Intel HAL's implememtation. The current default mode ia_aiq_frame_use_still is only used with the single capture request. For preview use case, it has hard time converging AE and AF smoothly. Change the default mode to ia_aiq_frame_use_preview for better user experience. Signed-off-by: Han-Lin Chen Reviewed-by: Umang Jain --- aiq/aiq_input_parameters.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp index 36e2b07..bc87b31 100644 --- a/aiq/aiq_input_parameters.cpp +++ b/aiq/aiq_input_parameters.cpp @@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults() { /*Ae Params */ aeInputParams.num_exposures = NUM_EXPOSURES; - aeInputParams.frame_use = ia_aiq_frame_use_still; + aeInputParams.frame_use = ia_aiq_frame_use_preview; aeInputParams.flash_mode = ia_aiq_flash_mode_off; aeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic; aeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative; @@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults() aeInputParams.manual_convergence_time = -1; /* AWB Params */ - awbParams.frame_use = ia_aiq_frame_use_still; + awbParams.frame_use = ia_aiq_frame_use_preview; awbParams.scene_mode = ia_aiq_awb_operation_mode_auto; awbParams.manual_convergence_time = -1.0; awbParams.manual_cct_range = nullptr; @@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults() /* AF Params */ afParams = { - ia_aiq_frame_use_still, 0, 1500, + ia_aiq_frame_use_preview, 0, 1500, ia_aiq_af_operation_mode_auto, ia_aiq_af_range_normal, ia_aiq_af_metering_mode_auto, @@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults() /* GBCE Params */ gbceParams.gbce_level = ia_aiq_gbce_level_bypass; gbceParams.tone_map_level = ia_aiq_tone_map_level_default; - gbceParams.frame_use = ia_aiq_frame_use_still; + gbceParams.frame_use = ia_aiq_frame_use_preview; gbceParams.ev_shift = 0; /* SA Params */ - saParams.frame_use = ia_aiq_frame_use_still; + saParams.frame_use = ia_aiq_frame_use_preview; } } /* namespace ipa::ipu3::aiq */