From patchwork Tue Oct 19 11:48:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 14185 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 44B62C324C for ; Tue, 19 Oct 2021 11:48:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0788368F59; Tue, 19 Oct 2021 13:48:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="G4fc48JF"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A83C668F5B for ; Tue, 19 Oct 2021 13:48:34 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.98]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 244E512A; Tue, 19 Oct 2021 13:48:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634644114; bh=+2iv9AcdAop1GHr1p6p2XOkrbZvLF8eoj0tQrRjYMdw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G4fc48JFscvLkTjJsxLP8D2mFTg0GrvkvEZUqdLi5z6m3fvRY49Q0hib4Ayc8epM1 MNIS8nn0jh7p8ct2Mx7qE20EDz7ASz9lwSSvaMUaihtwjSigepS4IpRWowd2KcH3RL CTiqj9ShWiWMePl+dbGxtmmoKAKBs+S+ZtbSeraA= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Tue, 19 Oct 2021 17:18:01 +0530 Message-Id: <20211019114802.665980-12-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211019114802.665980-1-umang.jain@ideasonboard.com> References: <20211019114802.665980-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 11/12] android: camera_stream: Define explicit move constructor and destructors X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Laurent Pinchart There's no need for the move constructor and the destructor to be inline. Define them explicitly, with default implementations. This allows usage of the CameraStream class without a complete definition of the PostProcessor class. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Jacopo Mondi --- src/android/camera_stream.cpp | 4 ++++ src/android/camera_stream.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp index 8e6ccb83..f44a2717 100644 --- a/src/android/camera_stream.cpp +++ b/src/android/camera_stream.cpp @@ -56,6 +56,10 @@ CameraStream::CameraStream(CameraDevice *const cameraDevice, { } +CameraStream::CameraStream(CameraStream &&other) = default; + +CameraStream::~CameraStream() = default; + const StreamConfiguration &CameraStream::configuration() const { return config_->at(index_); diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h index 85064268..f242336e 100644 --- a/src/android/camera_stream.h +++ b/src/android/camera_stream.h @@ -112,6 +112,8 @@ public: CameraStream(CameraDevice *const cameraDevice, libcamera::CameraConfiguration *config, Type type, camera3_stream_t *camera3Stream, unsigned int index); + CameraStream(CameraStream &&other); + ~CameraStream(); Type type() const { return type_; } camera3_stream_t *camera3Stream() const { return camera3Stream_; }