From patchwork Mon Oct 18 15:25:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 14173 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5B45EC324C for ; Mon, 18 Oct 2021 15:24:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D4DD868F59; Mon, 18 Oct 2021 17:24:41 +0200 (CEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A664168F56 for ; Mon, 18 Oct 2021 17:24:40 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id CACA740016; Mon, 18 Oct 2021 15:24:39 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 18 Oct 2021 17:25:24 +0200 Message-Id: <20211018152524.78521-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] Revert "android: camera_device: Configure one stream for identical stream requests" X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Commit d165f7da34b8 ("android: camera_device: Configure one stream for identical stream requests") introduced the ability to generate through post-processing YUV streams of identical size and format. Howver the change didn't fully take into account the situation where only mapped streams are contained in the request submitted by the camera service to the HAL. In this case the Request will be queued with no buffers and refused by the Camera. Even if this seems a corner case it causes a few CTS to fail, and more problematically it triggers out-of-order completion of requests, causing the camera service to abort. ERROR Camera camera.cpp:1031 Request contains no buffers ERROR HAL camera_device.cpp:1109 '\_SB_.PCI0.I2C2.CAM0': Out-of-order completion for request 0x00007a1f1800ccd0 ERROR cros_camera_service[15706:15711]: [camera_device_adapter.cc(744)] (15711) Notify(): Fatal device error; aborting the camera service Revert the commit until a proper solution is implemented. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Reviewed-by: Hirokazu Honda --- src/android/camera_device.cpp | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 901867105085..bd34188809da 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -619,35 +619,6 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) continue; } - /* - * While gralloc usage flags are supposed to report usage - * patterns to select a suitable buffer allocation strategy, in - * practice they're also used to make other decisions, such as - * selecting the actual format for the IMPLEMENTATION_DEFINED - * HAL pixel format. To avoid issues, we thus have to set the - * GRALLOC_USAGE_HW_CAMERA_WRITE flag unconditionally, even for - * streams that will be produced in software. - */ - stream->usage |= GRALLOC_USAGE_HW_CAMERA_WRITE; - - /* - * If a CameraStream with the same size and format of the - * current stream has already been requested, associate the two. - */ - auto iter = std::find_if( - streamConfigs.begin(), streamConfigs.end(), - [size, format](const Camera3StreamConfig &streamConfig) { - return streamConfig.config.size == size && - streamConfig.config.pixelFormat == format; - }); - if (iter != streamConfigs.end()) { - /* Add usage to copy the buffer in streams[0] to stream. */ - iter->streams[0].stream->usage |= GRALLOC_USAGE_SW_READ_OFTEN; - stream->usage |= GRALLOC_USAGE_SW_WRITE_OFTEN; - iter->streams.push_back({ stream, CameraStream::Type::Mapped }); - continue; - } - Camera3StreamConfig streamConfig; streamConfig.streams = { { stream, CameraStream::Type::Direct } }; streamConfig.config.size = size;