From patchwork Tue Oct 5 07:31:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 14049 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 79EEDBDC71 for ; Tue, 5 Oct 2021 07:31:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 49A1F691B9; Tue, 5 Oct 2021 09:31:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OfBuA1sX"; dkim-atps=neutral Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AF204691BD for ; Tue, 5 Oct 2021 09:31:33 +0200 (CEST) Received: by mail-pf1-x42c.google.com with SMTP id g2so16646752pfc.6 for ; Tue, 05 Oct 2021 00:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fhp6VldNPONO2CVYik2Y7RItvUuE5jx8y/8HeWR21IQ=; b=OfBuA1sX3PQGl3QdiNV8NjVWfwnwcApdBBC+AVfHSyFfX9resPO1IpeO6YPRBe6jcy XmyamOhvJ5svbwU92y61YTnJ2IMHjeS0RKh5KjJKeOAaYarrk9x1Tp5flP3XEm8lOy9V uulc7uOjL2DAa3j4T5kVw10pi6JNBYIxSiPpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fhp6VldNPONO2CVYik2Y7RItvUuE5jx8y/8HeWR21IQ=; b=1NlOUfjg9Z9icDul1+OIBFmZEhYj4lkldxr8rqpVqGTY/3qQ6tndsDE6rHwizHGZ6+ jP4r/2wGywFzytro9uVPSkfinBoAmPo13uq3Hoc4Ut0v3ChDkph47ZNYO7clVE7hSogR mlzdVroAKRe4eci2vAahEjWO1zc8v8ZSvIVP0DiI8CdI65Is5uAfIOwlZk9/TsXE5Dvr mgKKPt3OJ3b3meoqavG1shXFNGMuERdrotJArc+qc7LyvhKIrQ3npM8qA9WKE0VE1qRm AQf04IJM6hQmCgFXaFaLky6hsGWJE2AEHImTxMx8flR4SbBIGQ2m7Qp7LkbGxVYcxNoV UkAQ== X-Gm-Message-State: AOAM530xINrWW9kT6LkfvsI2uV/eXBadViLgebg7DHlhZ/XmiZ5iWKwx h9whj/viY+6JThzLPYZdAEFZUPUNlcNEwg== X-Google-Smtp-Source: ABdhPJyQkiylkda9Z/F7U23G9Z03SSfTtgcuo+2j/2bPY/n/Qij4zPF1FEUNaxCqffhp5HuzHDqeDg== X-Received: by 2002:a62:d11e:0:b0:446:d705:7175 with SMTP id z30-20020a62d11e000000b00446d7057175mr29448098pfg.74.1633419091991; Tue, 05 Oct 2021 00:31:31 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:203:debc:d0db:3bd8:f961]) by smtp.gmail.com with ESMTPSA id o14sm16761812pfh.145.2021.10.05.00.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 00:31:31 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 5 Oct 2021 16:31:13 +0900 Message-Id: <20211005073114.3997303-6-hiroh@chromium.org> X-Mailer: git-send-email 2.33.0.800.g4c38ced690-goog In-Reply-To: <20211005073114.3997303-1-hiroh@chromium.org> References: <20211005073114.3997303-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 5/6] lc-compliance: Remove using namespace in header files X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" "using namespace" in a header file propagates the namespace to the files including the header file. So it should be avoided. This removes "using namespace" in header files in lc-compliance. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/lc-compliance/environment.cpp | 2 +- src/lc-compliance/environment.h | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/lc-compliance/environment.cpp b/src/lc-compliance/environment.cpp index 9e24b5e3..f4583c8e 100644 --- a/src/lc-compliance/environment.cpp +++ b/src/lc-compliance/environment.cpp @@ -13,7 +13,7 @@ Environment *Environment::get() return &instance; } -void Environment::setup(CameraManager *cm, std::string cameraId) +void Environment::setup(libcamera::CameraManager *cm, std::string cameraId) { cm_ = cm; cameraId_ = cameraId; diff --git a/src/lc-compliance/environment.h b/src/lc-compliance/environment.h index 1c7d9a55..ba308732 100644 --- a/src/lc-compliance/environment.h +++ b/src/lc-compliance/environment.h @@ -9,23 +9,21 @@ #include -using namespace libcamera; - class Environment { public: static Environment *get(); - void setup(CameraManager *cm, std::string cameraId); + void setup(libcamera::CameraManager *cm, std::string cameraId); const std::string &cameraId() const { return cameraId_; } - CameraManager *cm() const { return cm_; } + libcamera::CameraManager *cm() const { return cm_; } private: Environment() = default; std::string cameraId_; - CameraManager *cm_; + libcamera::CameraManager *cm_; }; #endif /* __LC_COMPLIANCE_ENVIRONMENT_H__ */