From patchwork Wed Sep 29 13:30:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13981 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0C766C3243 for ; Wed, 29 Sep 2021 13:30:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D439E691B7; Wed, 29 Sep 2021 15:30:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Tr6nGDQD"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EB94A691A3 for ; Wed, 29 Sep 2021 15:30:44 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CFA4F3F0; Wed, 29 Sep 2021 15:30:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632922244; bh=HF2RWqvIo4vAjF6D7HhHAwYGz2JFm7Rf7UHkRkaVYUo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tr6nGDQDg3h8m5cQl/sQRLeMwMHJIB4FWHxz9DU4YBdxRc6Kw4uFYaClHjapDgRRw ugvFuzAGHrfftBWXAznxGvOFLoR6hepnKuKusE8juSM2owf9qSlyAOafLCSKQ8Sz/c knovSIVABalUmhB8Oe+vFjA8uqEZ7nSxiOpJIcak= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Wed, 29 Sep 2021 19:00:29 +0530 Message-Id: <20210929133030.401961-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210929133030.401961-1-umang.jain@ideasonboard.com> References: <20210929133030.401961-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 3/4] android: camera_device: Mark abortRequest() and notifyError() as const X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" abortRequest() and notifyError() do not access any members of CameraDevice hence, these functions can be const. Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/android/camera_device.cpp | 4 ++-- src/android/camera_device.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index e815f7a0..45350563 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor) return 0; } -void CameraDevice::abortRequest(camera3_capture_request_t *request) +void CameraDevice::abortRequest(camera3_capture_request_t *request) const { notifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST); @@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp) } void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream, - camera3_error_msg_code code) + camera3_error_msg_code code) const { camera3_notify_msg_t notify = {}; diff --git a/src/android/camera_device.h b/src/android/camera_device.h index 9ec510d5..85497921 100644 --- a/src/android/camera_device.h +++ b/src/android/camera_device.h @@ -99,11 +99,11 @@ private: createFrameBuffer(const buffer_handle_t camera3buffer, libcamera::PixelFormat pixelFormat, const libcamera::Size &size); - void abortRequest(camera3_capture_request_t *request); + void abortRequest(camera3_capture_request_t *request) const; bool isValidRequest(camera3_capture_request_t *request) const; void notifyShutter(uint32_t frameNumber, uint64_t timestamp); void notifyError(uint32_t frameNumber, camera3_stream_t *stream, - camera3_error_msg_code code); + camera3_error_msg_code code) const; int processControls(Camera3RequestDescriptor *descriptor); std::unique_ptr getResultMetadata( const Camera3RequestDescriptor &descriptor) const;