From patchwork Tue Sep 28 10:10:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 13964 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E5D8BBDC71 for ; Tue, 28 Sep 2021 10:10:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 248466918C; Tue, 28 Sep 2021 12:10:13 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jmK6uSEz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 28D4E69185 for ; Tue, 28 Sep 2021 12:10:12 +0200 (CEST) Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C6523F1; Tue, 28 Sep 2021 12:10:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632823811; bh=eOkMu3JR231qqC+Gu2JNizpg+9sI1jdVJ4OJcaHFFao=; h=From:To:Cc:Subject:Date:From; b=jmK6uSEzx3ZgHBS22GU4zfeNzvP3UeFqva+x/n4ONnq5FEiy71V1gEfOYfrkKO5u/ AFvpMef0jJCUKNtT7ieCH+poUO3RrkkXYTjosAd4d9+F7iFQFkn2eSw94r6kp4KjXu Iv7SMdeV+V8BPCHa4s+7oPipaK4S21bIIneCeYY4= From: Kieran Bingham To: libcamera devel Date: Tue, 28 Sep 2021 11:10:07 +0100 Message-Id: <20210928101007.452727-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPU3 interface was updated in 4c1fc33d8ab9 ("libcamera: ipu3: Drop entityControls map") where the sensor controls are given their own dedicated control list and is named accordingly. Update the IPU3 IPA to match the new interface update. Signed-off-by: Kieran Bingham Reviewed-by: Jean-Michel Hautbois Reviewed-by: Umang Jain Reviewed-by: Jacopo Mondi --- ipu3.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ipu3.cpp b/ipu3.cpp index 3e89e6dd4e02..b60c58c990af 100644 --- a/ipu3.cpp +++ b/ipu3.cpp @@ -201,14 +201,14 @@ int IPAIPU3::start() int IPAIPU3::configure(const IPAConfigInfo &configInfo) { - if (configInfo.entityControls.empty()) { - LOG(IPAIPU3, Error) << "No controls provided"; + if (configInfo.sensorControls.empty()) { + LOG(IPAIPU3, Error) << "No sensor controls provided"; return -ENODATA; } sensorInfo_ = configInfo.sensorInfo; - ctrls_ = configInfo.entityControls.at(0); + ctrls_ = configInfo.sensorControls; const auto itExp = ctrls_.find(V4L2_CID_EXPOSURE); if (itExp == ctrls_.end()) {