From patchwork Sun Sep 26 21:21:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 13940 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 23F55BDC71 for ; Sun, 26 Sep 2021 21:21:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 59B4069193; Sun, 26 Sep 2021 23:21:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="anQp44m4"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 27C626012D for ; Sun, 26 Sep 2021 23:21:17 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 975CBEF for ; Sun, 26 Sep 2021 23:21:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632691276; bh=3UhWg7gW0Xx2VJ2FBz+Mv1x1xOFk6RFxLW2QcxI08oY=; h=From:To:Subject:Date:From; b=anQp44m4hGw/Q/CmcizBxCCaEmapBwEhULerG9itoESU2/8BgUW8U9k07YpfrBztq 65vovotP5tGZvr11HPQOClz4miAZqE1A0UvRAozimOtKYMNwDOg/+7hwsLTfMntjUL eq7AvWr4D20OtC5wIewDLQKkRNRQ9aBOp4lJyCEc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Mon, 27 Sep 2021 00:21:06 +0300 Message-Id: <20210926212108.22510-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] Documentation: application-developer: Make global variable static X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The global "camera" variable isn't accessed outside of its compilation unit. Make it static. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham --- Documentation/guides/application-developer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 72e8e03719aa552abce7eeee8a6e4a9b8eb8443e diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst index ae28c96b5aca..3de13060db08 100644 --- a/Documentation/guides/application-developer.rst +++ b/Documentation/guides/application-developer.rst @@ -58,7 +58,7 @@ variable for the camera to support the event call back later: .. code:: cpp - std::shared_ptr camera; + static std::shared_ptr camera; Create a Camera Manager instance at the beginning of the main function, and then start it. An application must only create a single Camera Manager instance.