From patchwork Thu Sep 23 12:05:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 13911 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B8863BDC71 for ; Thu, 23 Sep 2021 12:05:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 28C6F6918C; Thu, 23 Sep 2021 14:05:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Nhaqw1S8"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DF2769189 for ; Thu, 23 Sep 2021 14:05:32 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:392e:dcd2:2bf6:d61c]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E860145E; Thu, 23 Sep 2021 14:05:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632398732; bh=d7RWYy6bxEug4X//hGDdi5qyv0kuX2wHbTCBnUWrDwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nhaqw1S8oT2GzBl+F5to2d8BudaMm4327mmy14KsrIPGo6Dp4VL/Y+0R6dc76hz0X vGamlr0e7+fDGttB2Qlis0nWssNsb5+hA8SqVbWyNKTiFzA/vpHQaeH0R5JdNjrDAq tIemTo57gkDTi/JcOGKwYuqTBUte4YFUUYADzyn4= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Thu, 23 Sep 2021 14:05:24 +0200 Message-Id: <20210923120524.76740-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210923081625.60276-7-jeanmichel.hautbois@ideasonboard.com> References: <20210923081625.60276-7-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] fixup! ipa: ipu3: Change limits and split loops in calculateBdsGrid() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi JM, I think you should take this fixup for your v2 ;-). --- src/ipa/ipu3/ipu3.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 06d9bcb8..3868a3a5 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -321,6 +321,7 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize) bestLog2.width = shift; } + minError = std::numeric_limits::max(); for (shift = kMinCellSizeLog2; shift <= kMaxCellSizeLog2; ++shift) { uint32_t height = std::clamp(bdsOutputSize.height >> shift, kMinCellHeightPerSet,