From patchwork Wed Sep 22 17:06:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vedant Paranjape X-Patchwork-Id: 13887 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 530ABBF01C for ; Wed, 22 Sep 2021 17:06:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6F3C46918E; Wed, 22 Sep 2021 19:06:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lDkqqxPV"; dkim-atps=neutral Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D47426917F for ; Wed, 22 Sep 2021 19:06:37 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id lb1-20020a17090b4a4100b001993f863df2so2796263pjb.5 for ; Wed, 22 Sep 2021 10:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m0IOy9xV7ZQ59xAegyYtbmAlKakfY/oio24R7bAtKRc=; b=lDkqqxPV2ZTJL35dRDWihaL3JtYhTnPbUeFeJUb7CwLeTtK9ZycUDA5ovb2Sm8Z3bu f+B6b58ptWXM6W5dANwdeWR2EibENWMbbpnaUM7Pf5/QkGx/LRh/SH4v0w/A10XJWjwK 7fvpdfZkN1AmtQEHRaSIZz8v/Qp72qehoCaHCTdQ78i4TvqvDXZ6zvaT19kRPJGV8pay LK3UuWXTgNJQ9x/YFbGqFA2hBBSW6mU6En/AScRX+0Kksknwmr+ARYy0ULGd+hsCN6Rc MtIU0GPEKtxrAzVzuud5og5OUhu7o/ts2tYmBNB9yAjnGGJjp4rBfekN8qlbxmXu1eyr O7fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m0IOy9xV7ZQ59xAegyYtbmAlKakfY/oio24R7bAtKRc=; b=fV/TpEtwEpOGWwO1XU6rMG6TnCa3abu8X1Pd1ZAPmcQltrbgWHZExlqO6UoZQfjq2U TKOsnpX9xlu2FZeyrD1FbQPVo+NFKS43rhEl6Oub4XnD+rYKCcYCocXFLZrg3CTAobUs 8XJqRo29XIpurWPx1tMHawJ6RZPYdxjDnTK7I+HimYosSuHaEJWwoZJGT30zYLJO9gg9 JDICru2SRndrSDgm5pj2vLgd60/gDEF/JPzAJBZf+Xh+8bhtH+t8nzWg0PlbqfN6eMy1 epHFjU07AEERTsGIiERV/KG1HX7yFLP/rksSdYLoLcQsC+DREAerF3+PyeGkoLxwxXo3 Cz2w== X-Gm-Message-State: AOAM532v+knrv+0heLStvNTx/nIbtilEU7dYNKyS/Wjs1uxrSxcYqKPn ZaDeOD6/g0dmL+qBJ5sHLIMv+gCrCVZFfw== X-Google-Smtp-Source: ABdhPJyGSavAiLXStwwSSd4Xz80U33BP6Lw7/6pOj7n7+wagWs59pXxhlIwLRX2FqROjpWOjSJQ8MQ== X-Received: by 2002:a17:902:c942:b0:13c:88f9:1af8 with SMTP id i2-20020a170902c94200b0013c88f91af8mr619300pla.3.1632330395652; Wed, 22 Sep 2021 10:06:35 -0700 (PDT) Received: from localhost.localdomain ([1.186.167.167]) by smtp.googlemail.com with ESMTPSA id x10sm6218257pjv.57.2021.09.22.10.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 10:06:35 -0700 (PDT) From: Vedant Paranjape To: libcamera-devel@lists.libcamera.org Date: Wed, 22 Sep 2021 22:36:19 +0530 Message-Id: <20210922170619.421818-1-vedantparanjape160201@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1] gstreamer: Convert cm_singleton_ptr to static variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vedant Paranjape Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The global pointer pointing to libcamera's CameraManager isn't used outside of the gstlibcamera-utils.cpp compilation unit. Make it static. Signed-off-by: Vedant Paranjape Reviewed-by: Nicolas Dufresne Reviewed-by: Jean-Michel Hautbois Reviewed-by: Umang Jain --- src/gstreamer/gstlibcamera-utils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp index 0af91c1acb67..c434bca65174 100644 --- a/src/gstreamer/gstlibcamera-utils.cpp +++ b/src/gstreamer/gstlibcamera-utils.cpp @@ -223,7 +223,7 @@ gst_libcamera_resume_task(GstTask *task) } G_LOCK_DEFINE_STATIC(cm_singleton_lock); -std::weak_ptr cm_singleton_ptr; +static std::weak_ptr cm_singleton_ptr; std::shared_ptr gst_libcamera_get_camera_mananger(int &ret)