From patchwork Tue Sep 21 17:39:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vedant Paranjape X-Patchwork-Id: 13881 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A5580BF01C for ; Tue, 21 Sep 2021 17:40:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 644D569191; Tue, 21 Sep 2021 19:40:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HrvX5kJs"; dkim-atps=neutral Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 564FB6918A for ; Tue, 21 Sep 2021 19:40:25 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id c1so148943pfp.10 for ; Tue, 21 Sep 2021 10:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+Ae9N/Ehz4QT7RYpuRU7NvHlnRTxJlESW1W2mEkgbGg=; b=HrvX5kJsYIGMeH1I8RYGxMJhicwcuUre4dw9dg6igYoVAmg6K1EoDXTgulLdsuXLeJ nAWr6aIisvMRpWLJ3ghG3DBxxAmjp3+QTY1SO71lUssLGq584vH692MKKqraRtupGEth FmxA46xlXtQFlLKUqMRKeHkU3UBTLQpKA0UE6bYfiNuog5i/tRJX8v4KYgYX5hTWR0Xu 9Jt46dW2hWOJCDQwks2Hnnq5U8H5sK2HxOyG0cx5UkY6/UKzvb/xOiYWwsnA2S3tsmWs qgxxfOv/sM/3cJLf5zmPYw/C1MWMuYUsNZU/jBtilqnQK8QK6udBCRihU/Zq/vTdXdhe MKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+Ae9N/Ehz4QT7RYpuRU7NvHlnRTxJlESW1W2mEkgbGg=; b=n/LUq7YMyhrPyfaK92ikXJudnVBB4NiLohes06HCJB2fg4L9k+FjkhKFW4VZhRZe/y fV/vL0Pw383XugeEzpSwBXC13q/VhkLaIAvLMFGLyXnfEZlLUQ15akOn8zSj0sFnyZnj vZJteSWyn7zP+CAEnWEwwigyNMc0DR8ndhY4eh8vfYvOAoRRHGyV356GiEpRHFW/YaEp URKJfoEW9aukoDp3bx6by99QIlX60i02ma2g9oQVfsmAUaFb4I82a4Y/O91zeBDXCWEI JR+ihDShVQ3uZjTFFbefRPhgBXOZmd6yhoq/Q0o5x4sWneL0m8q6U4dAdQtHmeH1PFyo AVpw== X-Gm-Message-State: AOAM533Qa4MoIzlp4mZnTlnAuM6uelWyD0Pfl0XzhTeDNj1eqI9aCb3I 0gRNzTORxGBZh7JWI+5xEfguLpSCpcOpZ7/Z X-Google-Smtp-Source: ABdhPJy0/of+yIpHQw/cdmicN4OamsCuh7bjNoQmSndJdYXLU3WcsYAZoIFesoRcGIJoix6tsbWOTA== X-Received: by 2002:a63:774e:: with SMTP id s75mr15830187pgc.73.1632246023625; Tue, 21 Sep 2021 10:40:23 -0700 (PDT) Received: from localhost.localdomain ([1.186.167.167]) by smtp.googlemail.com with ESMTPSA id k190sm19800772pgc.11.2021.09.21.10.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 10:40:23 -0700 (PDT) From: Vedant Paranjape To: libcamera-devel@lists.libcamera.org Date: Tue, 21 Sep 2021 23:09:55 +0530 Message-Id: <20210921173955.20408-3-vedantparanjape160201@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210921173955.20408-1-vedantparanjape160201@gmail.com> References: <20210921173955.20408-1-vedantparanjape160201@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 3/3] test: gstreamer: Simplify elements' ownerships X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Dufresne , Vedant Paranjape Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In gstreamer, when elements are created, usually a floating [1] reference is returned which simply means, there is no ownership transfer (yet). Once can simply check for NULL and return through an error path, without bothering to clean up. Hence, g_autoptr is not much of help here. If the NULL checks have been passed successfully, elements are ready to use. However, we must claim ownership/reference it before using them via g_object_ref_sink(). This patch build upon this principle and removes the g_autoptr from gstreamer test base class (gstreamer_test.cpp) whereever necessary to tide up the code. [1] https://gstreamer.freedesktop.org/documentation/additional/design/MT-refcounting.html?gi-language=c#refcounting1 Signed-off-by: Vedant Paranjape Signed-off-by: Umang Jain Reviewed-by: Nicolas Dufresne Reviewed-by: Paul Elder --- test/gstreamer/gstreamer_test.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp index 4171250584e6..227a5c37fbe1 100644 --- a/test/gstreamer/gstreamer_test.cpp +++ b/test/gstreamer/gstreamer_test.cpp @@ -78,18 +78,17 @@ GstreamerTest::~GstreamerTest() int GstreamerTest::createPipeline() { - g_autoptr(GstElement) libcameraSrc = gst_element_factory_make("libcamerasrc", "libcamera"); + libcameraSrc_ = gst_element_factory_make("libcamerasrc", "libcamera"); pipeline_ = gst_pipeline_new("test-pipeline"); - g_object_ref_sink(libcameraSrc); - if (!libcameraSrc || !pipeline_) { + if (!libcameraSrc_ || !pipeline_) { g_printerr("Unable to create create pipeline %p.%p\n", - libcameraSrc, pipeline_); + libcameraSrc_, pipeline_); return TestFail; } - libcameraSrc_ = reinterpret_cast(g_steal_pointer(&libcameraSrc)); + g_object_ref_sink(libcameraSrc_); return TestPass; }