From patchwork Tue Sep 21 17:39:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vedant Paranjape X-Patchwork-Id: 13879 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0EF9ABF01C for ; Tue, 21 Sep 2021 17:40:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 503266918C; Tue, 21 Sep 2021 19:40:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J7c00G9k"; dkim-atps=neutral Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C91ED60247 for ; Tue, 21 Sep 2021 19:40:15 +0200 (CEST) Received: by mail-pf1-x42d.google.com with SMTP id w14so211962pfu.2 for ; Tue, 21 Sep 2021 10:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AjTUusiayGb8XNBYuRtkKRQ3PtUl1WcJg3+jWBjSajQ=; b=J7c00G9kQFqssmixNylVrlcnWDCBzlQpt59zi0Svb1b6BHKPDrbgLq2W/Fb1RZ1KET C0wbhLqGnnBlw9di+Hx3cl/8+brTQQhCtx37hNVTbDytI+dlJ5+WZK7bop+SyxMkL5JN QFHsgM9ThB/PRNNiI+cgvD5rpKGht4ZaqbR3gYFm5S2vcc1WiNMLo8u1LZHyW3sEJW9t 6G3mgBCt+Nh7aaodGsTacGvv3DR4nHzrTDGdaqdZ6NM0lk48iyftC2we3zSEiTOP3/Ib DjKn48ZqAFNnvbuMiduDYd6RXCG2jn3VT13n+7QPkzhLW+koqPxCQ8N981RikOP0Cy16 6elg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AjTUusiayGb8XNBYuRtkKRQ3PtUl1WcJg3+jWBjSajQ=; b=D0GUSKSRBhMR2zuFe6Etxth0XfSPlVul69k2OTotrv6xfhrcNRXayAuSL/RxMz0aHQ Xijv9u0d2cX+g3zSAetKzQ4zcxEjB3yAj1eomy/CmX9v5V7QJ2IBU3tQKAWvPiGhm2R2 h6gfg9ab3gHilxsQ1GkqZMC//IFCvrDD6YKNFtOebXzCSMG49OsUndK6AcDzqXUNC3il WRNL9mJaQwsKqSSHlacymus5J5zLw7jQeltLfhGMhH2cOhGd5OGD3Xq9ex299F3qg3T7 wao8jFrw9HEzq/Q7HwhAE2K8Idh15iodRAug12nqLi/w4jYrznk9/n1P5b0gYxuexZfs drmA== X-Gm-Message-State: AOAM531HrT/ilHtBAsfbU4Fk7JGYCEnSz9rMK3pf874kBTL9KTJAsvF6 HYkmFWEQ6SyOdp2hKgfuA2eZmAGCbBvU2gdX X-Google-Smtp-Source: ABdhPJzo0NTMaousF8N6WcsWTAjQ22RijK3BRoOsgfCTaKMaOqWmGlaSDKUWd0D4Y9IQIPom6wlVbA== X-Received: by 2002:a62:ce0d:0:b0:438:71f1:4442 with SMTP id y13-20020a62ce0d000000b0043871f14442mr32215187pfg.21.1632246013857; Tue, 21 Sep 2021 10:40:13 -0700 (PDT) Received: from localhost.localdomain ([1.186.167.167]) by smtp.googlemail.com with ESMTPSA id k190sm19800772pgc.11.2021.09.21.10.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 10:40:13 -0700 (PDT) From: Vedant Paranjape To: libcamera-devel@lists.libcamera.org Date: Tue, 21 Sep 2021 23:09:53 +0530 Message-Id: <20210921173955.20408-1-vedantparanjape160201@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/3] test: gstreamer_single_stream_test: Fix memory leak X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Dufresne , Vedant Paranjape Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The test hold a valid reference to convert0_ and sink0_ but not released. This results in a memory leak and can be checked via valgrind. Drop the references with test cleanup() virtual function. Valgrind log (glib and gst suppression files were used): ==345380== LEAK SUMMARY: ==345380== definitely lost: 1,688 bytes in 2 blocks ==345380== indirectly lost: 7,069 bytes in 42 blocks The patch fixes the leaks reported by valgrind above to: ==348870== LEAK SUMMARY: ==348870== definitely lost: 0 bytes in 0 blocks ==348870== indirectly lost: 0 bytes in 0 blocks Signed-off-by: Vedant Paranjape Signed-off-by: Umang Jain Reviewed-by: Nicolas Dufresne Reviewed-by: Paul Elder --- test/gstreamer/gstreamer_single_stream_test.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp index 7292f3280617..2b561d6bf9f2 100644 --- a/test/gstreamer/gstreamer_single_stream_test.cpp +++ b/test/gstreamer/gstreamer_single_stream_test.cpp @@ -72,6 +72,12 @@ protected: return TestPass; } + void cleanup() override + { + g_clear_object(&convert0_); + g_clear_object(&sink0_); + } + private: GstElement *convert0_; GstElement *sink0_;