From patchwork Tue Sep 21 11:56:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vedant Paranjape X-Patchwork-Id: 13875 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 62D81BDC71 for ; Tue, 21 Sep 2021 11:56:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BA02C6918A; Tue, 21 Sep 2021 13:56:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Eo9wtLPT"; dkim-atps=neutral Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 03CF860247 for ; Tue, 21 Sep 2021 13:56:27 +0200 (CEST) Received: by mail-pg1-x52e.google.com with SMTP id g184so20453940pgc.6 for ; Tue, 21 Sep 2021 04:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AjTUusiayGb8XNBYuRtkKRQ3PtUl1WcJg3+jWBjSajQ=; b=Eo9wtLPTwScp/79+GQkakjzWElUPvNdfo/DZra2jhXWwyEaUNthNJ1jfIHQ6ADY8GR sBeIQ0QCMbFxzCc13IRcTbydk85uJXFi66KMER2mtnMOmHquXYcY7CKrUu9oq76TkAyT YdpGrN8FMsjKwfGvBlpsQjOwkdg1Qh93suc6EVXB7DnqB6cB/WU2bpKUyRBlq8Tz8dws G4b8QoJMbK34bwC37I6QBVGjo33+LJkBpdb9NC3zaskCUKEXhCWiCSZWpIVggOPbHjgD BV81M/pMENtRSAgLftjjntOJnh53B4kfRq0IzornmcLGktZmU7coBXADvAgvZWvUpiRl WMmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AjTUusiayGb8XNBYuRtkKRQ3PtUl1WcJg3+jWBjSajQ=; b=wOeQmKs2iQEd+YCVoqSpJCNIhMicKCaGjEkFlCiePwO/54tDjK4IMyWFKP/euh7u61 YNUjy78JS00aB0w4N73620QNyzaN5pLACNkGTSW/zehTh3hCWI3taEMpjYYjiKxIoSnE sQMpU8Wfp0VN1hcLE5r/azO4VunRK/Jv56GEi65ekJYcv/CBRwMW4PnhpEUNCO+CUUdD sD0tGpkwP5LmZxbhjijGQXx7ovlazM9EmSbowNd+t+UPe44d23sTGPVHLfGiPekyRMaq Vz7hJCjupK3Pnui7mjULU6IU1ub9rVN2mNeZsuXkKOa+p45hY+OeJskVWdUPnlIY4nMJ oyxg== X-Gm-Message-State: AOAM531C47sHufRVi925adSFU+hJKluRvJgsg5by0kDpBuKA6jk55hN9 am7C5uYsNLNSsVUxhiVWUTdpLntEloRTTw== X-Google-Smtp-Source: ABdhPJwpMgy++9+ThNBA2BrV576aH8VroXj17N9ZKDmC/D4sDBdLemQFNTFGoZn1sZXULQR1NAb0gQ== X-Received: by 2002:a63:788d:: with SMTP id t135mr27507177pgc.116.1632225385057; Tue, 21 Sep 2021 04:56:25 -0700 (PDT) Received: from localhost.localdomain ([1.186.167.167]) by smtp.googlemail.com with ESMTPSA id y5sm16654906pfb.207.2021.09.21.04.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 04:56:24 -0700 (PDT) From: Vedant Paranjape To: libcamera-devel@lists.libcamera.org Date: Tue, 21 Sep 2021 17:26:08 +0530 Message-Id: <20210921115610.366553-1-vedantparanjape160201@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 1/3] test: gstreamer_single_stream_test: Fix memory leak X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Dufresne , Vedant Paranjape Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The test hold a valid reference to convert0_ and sink0_ but not released. This results in a memory leak and can be checked via valgrind. Drop the references with test cleanup() virtual function. Valgrind log (glib and gst suppression files were used): ==345380== LEAK SUMMARY: ==345380== definitely lost: 1,688 bytes in 2 blocks ==345380== indirectly lost: 7,069 bytes in 42 blocks The patch fixes the leaks reported by valgrind above to: ==348870== LEAK SUMMARY: ==348870== definitely lost: 0 bytes in 0 blocks ==348870== indirectly lost: 0 bytes in 0 blocks Signed-off-by: Vedant Paranjape Signed-off-by: Umang Jain Reviewed-by: Nicolas Dufresne --- test/gstreamer/gstreamer_single_stream_test.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp index 7292f3280617..2b561d6bf9f2 100644 --- a/test/gstreamer/gstreamer_single_stream_test.cpp +++ b/test/gstreamer/gstreamer_single_stream_test.cpp @@ -72,6 +72,12 @@ protected: return TestPass; } + void cleanup() override + { + g_clear_object(&convert0_); + g_clear_object(&sink0_); + } + private: GstElement *convert0_; GstElement *sink0_;