From patchwork Fri Sep 10 07:06:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13803 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DAB87BDC71 for ; Fri, 10 Sep 2021 07:06:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 999026916D; Fri, 10 Sep 2021 09:06:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wK8/itDF"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D356369169 for ; Fri, 10 Sep 2021 09:06:56 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.149]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CE520883; Fri, 10 Sep 2021 09:06:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1631257616; bh=EjrgOUPInzOsFwr8WIeUqDQz29bU+sJYG1tCgeGwvbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wK8/itDFrmrBKEYxWXGA7OG4tMnoop7B2QLYY9QfyCyeS7Li4kW0Tatn2xWDvkg8g 9jMp5LkfHUqVD5DT1UPNSKJoEpzg6tm/3spKQdyvU1ppzT9C+tK/yA23ocr9FXw5HW 25CTvQLkrHZ0JhoV6tn4TcYmXShBKgb6NC96Lxrk= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Fri, 10 Sep 2021 12:36:34 +0530 Message-Id: <20210910070638.467294-6-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210910070638.467294-1-umang.jain@ideasonboard.com> References: <20210910070638.467294-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/9] android: camera_stream: Query post-processing status X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" CameraStream takes care of any post-processing required via the CameraStream::process(). Since the post-processor will be moved to a separate thread (in subsequent commits), the caller of PostProcessor::process() will notify the associated CameraStream instance about the post-processing completion via processComplete signal. The CameraStream class should handle this event to query the status and take next steps of reporting it back to upper layers (i.e. CameraDevice). Signed-off-by: Umang Jain --- src/android/camera_stream.cpp | 13 +++++++++++++ src/android/camera_stream.h | 13 ++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp index d1c54797..996779c4 100644 --- a/src/android/camera_stream.cpp +++ b/src/android/camera_stream.cpp @@ -81,6 +81,9 @@ int CameraStream::configure() int ret = postProcessor_->configure(configuration(), output); if (ret) return ret; + + postProcessor_->processComplete.connect( + this, &CameraStream::postProcessingComplete); } if (allocator_) { @@ -123,6 +126,16 @@ int CameraStream::process(const FrameBuffer *source, resultMetadata, context); } +void CameraStream::postProcessingComplete(PostProcessor::Status status, + const Camera3RequestDescriptor *context) +{ + ProcessStatus processStatus; + if (status == PostProcessor::Status::Succeeded) + processStatus = ProcessStatus::Succeeded; + else + processStatus = ProcessStatus::Failed; +} + FrameBuffer *CameraStream::getBuffer() { if (!allocator_) diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h index d589f699..be076995 100644 --- a/src/android/camera_stream.h +++ b/src/android/camera_stream.h @@ -13,15 +13,18 @@ #include +#include + #include #include #include #include #include +#include "post_processor.h" + class CameraDevice; class CameraMetadata; -class PostProcessor; struct Camera3RequestDescriptor; @@ -128,7 +131,15 @@ public: libcamera::FrameBuffer *getBuffer(); void putBuffer(libcamera::FrameBuffer *buffer); + enum ProcessStatus { + Succeeded, + Failed, + }; + private: + void postProcessingComplete(PostProcessor::Status status, + const Camera3RequestDescriptor *context); + CameraDevice *const cameraDevice_; const libcamera::CameraConfiguration *config_; const Type type_;