From patchwork Tue Sep 7 19:41:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 13747 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 17FAEBDB1D for ; Tue, 7 Sep 2021 19:40:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C4DF36917C; Tue, 7 Sep 2021 21:40:44 +0200 (CEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B13A66917D for ; Tue, 7 Sep 2021 21:40:41 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4D9AB240002; Tue, 7 Sep 2021 19:40:41 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Tue, 7 Sep 2021 21:41:06 +0200 Message-Id: <20210907194107.803730-17-jacopo@jmondi.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210907194107.803730-1-jacopo@jmondi.org> References: <20210907194107.803730-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 16/17] Revert "android: capabilities: Cap frame rate to 30 FPS" X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This reverts commit 257df463ad0e0862c211b03742140a99dd8cc0ef. --- src/android/camera_capabilities.cpp | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp index cff1e30a9567..deaec3282fd7 100644 --- a/src/android/camera_capabilities.cpp +++ b/src/android/camera_capabilities.cpp @@ -632,29 +632,6 @@ int CameraCapabilities::initializeStreamConfigurations() int64_t minFrameDuration = frameDurations->second.min().get() * 1000; int64_t maxFrameDuration = frameDurations->second.max().get() * 1000; - - /* - * Cap min frame duration to 30 FPS. - * - * 30 frames per second has been validated as the most - * opportune frame rate for quality tuning, and power - * vs performances budget on Intel IPU3. - * - * \todo This is a platform-specific decision that needs - * to be abstracted and delegated to the configuration - * file. - * - * \todo libcamera only allows to control frame duration - * through the per-request controls::FrameDuration - * control. If we cap the durations here, we should be - * capable of configuring the camera to operate at such - * duration without requiring to have the FrameDuration - * control to be specified for each Request. Defer this - * to the in-development configuration API rework. - */ - if (minFrameDuration < 1e9 / 30.0) - minFrameDuration = 1e9 / 30.0; - streamConfigurations_.push_back({ res, androidFormat, minFrameDuration, maxFrameDuration, });