From patchwork Tue Aug 24 14:24:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 13463 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA7A2C3241 for ; Tue, 24 Aug 2021 14:25:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5A15268919; Tue, 24 Aug 2021 16:25:00 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HgHdRASD"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E13B688C4 for ; Tue, 24 Aug 2021 16:24:56 +0200 (CEST) Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 172333F0; Tue, 24 Aug 2021 16:24:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1629815095; bh=B3zrvpiFuR119fYKAR7dixmI8rpS7lMvWvhVNUsyPII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HgHdRASDekk8prZt4oR7elhWu2XDzS7OSuK3jLd1OL0w/fd/ux3gK8ya71frV7Wn/ lzKoPm6jsOBoqNh96eoqQllo7uBh1Erfdnqfl2K+8R1935R7gj6XLtpkiJX4H4lJbe kO9WjKfJ2qUnYvXg10bnQ5Y3t3nHid3WjJuUhH/I= From: Kieran Bingham To: libcamera devel Date: Tue, 24 Aug 2021 15:24:47 +0100 Message-Id: <20210824142450.3157833-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210824142450.3157833-1-kieran.bingham@ideasonboard.com> References: <20210824142450.3157833-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [SimpleCam PATCH 1/4] simple-cam: Use a unique_ptr for the CameraManager X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CameraManager should be released when it is no longer used. A unique_ptr will handle this automatically, and convey the lifetime of the object. Update simple-cam to show that managing the lifetime of the CameraManager is recommended practice. Signed-off-by: Kieran Bingham Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- simple-cam.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/simple-cam.cpp b/simple-cam.cpp index 8f7012b83b6c..5c16db67700c 100644 --- a/simple-cam.cpp +++ b/simple-cam.cpp @@ -131,8 +131,15 @@ int main() * * The CameraManager provides a list of available Cameras that * applications can operate on. + * + * When the CameraManager is no longer to be used, it should be deleted. + * We use a unique_ptr here to manage the lifetime automatically during + * the scope of this function. + * + * There can only be a single CameraManager constructed within any + * process space. */ - CameraManager *cm = new CameraManager(); + std::unique_ptr cm = std::make_unique(); cm->start(); /*