From patchwork Thu Aug 12 04:22:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 13324 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 443DDBD87D for ; Thu, 12 Aug 2021 04:23:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B6CF86884D; Thu, 12 Aug 2021 06:23:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="STknoXGT"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 86B9760260 for ; Thu, 12 Aug 2021 06:22:59 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 079B2EE; Thu, 12 Aug 2021 06:22:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628742179; bh=Nr5yDMDDpW7dYJqhVlwfYjcvUZLyG5P4I9EFYEUj2as=; h=From:To:Cc:Subject:Date:From; b=STknoXGT58VRfVWEWUx85qSQvlBbGw2YNrWfag+YQIWFOOIwifHvy9LOr6diK7WGI R5ffwT4qUDHUuJVVWayZQDbyeYEGvmXZ8Thc6t0byKUvZaO1Qc056xTEYbUtBhNoGf lTE+WSxrKO4Grvw5xL/BwE2B3Irt23czc5iy2wDA= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Thu, 12 Aug 2021 13:22:49 +0900 Message-Id: <20210812042249.1073932-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The min-max constructor is not the proper constructor for boolean ControlInfos. Use the proper boolean constructor. Signed-off-by: Paul Elder Reviewed-by: Jacopo Mondi --- Changes in v2: - whoops, sorry v1 was based on Jacopo's "libcamera: Initialize controls in the IPA" --- include/libcamera/ipa/raspberrypi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h index a8790000..7ef14e57 100644 --- a/include/libcamera/ipa/raspberrypi.h +++ b/include/libcamera/ipa/raspberrypi.h @@ -28,7 +28,7 @@ namespace RPi { * unsupported control is encountered. */ static const ControlInfoMap Controls = { - { &controls::AeEnable, ControlInfo(false, true) }, + { &controls::AeEnable, ControlInfo({false, true}, true) }, { &controls::ExposureTime, ControlInfo(0, 999999) }, { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) }, { &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },