From patchwork Wed Aug 11 08:05:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 13300 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 37793C3240 for ; Wed, 11 Aug 2021 08:05:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 82B0D6884F; Wed, 11 Aug 2021 10:05:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u/EsWhV6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7560060265 for ; Wed, 11 Aug 2021 10:05:50 +0200 (CEST) Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EACFEEE; Wed, 11 Aug 2021 10:05:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628669150; bh=eNlLObYRb5MFVEf/ZQ0ThmocwgeQ97pgmcPYI0NQUXE=; h=From:To:Cc:Subject:Date:From; b=u/EsWhV6AvBVLWZT85M0U/wzYA9IacsccvopRkdIhlyzqIFf916zvb2/SMDbGrKvD zjAfd3midjDGMB66UYtLLWvrNZPdFD6M6O2KkLxe7QqLbcrdANV0taAaR/F0gUikho pbcjbhE1ZIVtaBClEGqHsCAJ6GO/+znIKXXLz3LM= From: Kieran Bingham To: libcamera devel Date: Wed, 11 Aug 2021 09:05:46 +0100 Message-Id: <20210811080546.2266825-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] base: class: Remove undesired semi-colon from LIBCAMERA_O_PTR X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The LIBCAMERA_O_PTR() define adds the ';' at the end of the templated call to _o(). While this works for the only current user in camera_manager.cpp, even the statement there adds another semi-colon following it. The addition of the semi-colon in the define unnecessarily prohibits the macro from being used in places other than the end of a statement. Remove it. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- include/libcamera/base/class.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/base/class.h b/include/libcamera/base/class.h index a5946836d2b9..02bbd91f93f8 100644 --- a/include/libcamera/base/class.h +++ b/include/libcamera/base/class.h @@ -50,7 +50,7 @@ public: \ using Public = klass; #define LIBCAMERA_O_PTR() \ - _o(); + _o() #else #define LIBCAMERA_DECLARE_PRIVATE()