From patchwork Thu Aug 5 22:24:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 13241 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8C58EC323F for ; Thu, 5 Aug 2021 22:25:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BE65E688C4; Fri, 6 Aug 2021 00:25:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BbRA8H/9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 161776026E for ; Fri, 6 Aug 2021 00:24:59 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7B8EE1A for ; Fri, 6 Aug 2021 00:24:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628202298; bh=onBRKaLyfm/6CNuVZw+yrSXTsWxSPIsGaRDjGdCdkdE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=BbRA8H/9fqBC4OIzrkFqrpiV0oJb7oBegCRrV22tCReBBJyDMqOlXK5pJvJJS3HXf kkMulstepF7dVnOH0I5ldE1pjJ62XDBbsQsM6kT/+8TOD5TPTC9Bpz/txsDXI5382n NBVX9jVdNhXG5HPNl6SWMe0lW5y+bJTFxyfxufY4= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 6 Aug 2021 01:24:36 +0300 Message-Id: <20210805222436.6263-11-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210805222436.6263-1-laurent.pinchart@ideasonboard.com> References: <20210805222436.6263-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 10/10] libcamera: pipeline: simple: Remove SimplePipelineHandler::activeCamera_ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The SimplePipelineHandler activeCamera_ member pointer is set but never used. Drop it. Signed-off-by: Laurent Pinchart --- src/libcamera/pipeline/simple/simple.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index aa4542ed26b1..7e89e3921dbe 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -312,8 +312,6 @@ private: std::map entities_; MediaDevice *converter_; - - Camera *activeCamera_; }; /* ----------------------------------------------------------------------------- @@ -1025,8 +1023,6 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL video->queueBuffer(buffer.get()); } - activeCamera_ = camera; - return 0; } @@ -1044,7 +1040,6 @@ void SimplePipelineHandler::stop(Camera *camera) video->bufferReady.disconnect(data, &SimpleCameraData::bufferReady); data->converterBuffers_.clear(); - activeCamera_ = nullptr; releasePipeline(data); }