From patchwork Thu Aug 5 08:35:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13205 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0FB21C3235 for ; Thu, 5 Aug 2021 08:36:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C0AD76880F; Thu, 5 Aug 2021 10:36:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kG04bZ+P"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B6A9F687CB for ; Thu, 5 Aug 2021 10:36:05 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.40]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E7DAE1A; Thu, 5 Aug 2021 10:36:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628152565; bh=ljDT0ojHAv/lh+/fkmzLQjcMqVFCX3K7MsIuWGC2qm4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kG04bZ+PqTG7bxPGioFU/YbE2rmx9BkzgHBt7GeInKkbvMRuOfp/H/2jUVcna6jen HnZqP+AS3rEK7DwwhORy8xWaDZNDHz17grL+3UxsmIfYS8EVlD9x4TtmW75yJS46Y7 qY/ZedPt3S/0gNrT1jSXNZC8A74kzDOo9pYqRD5k= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Thu, 5 Aug 2021 14:05:51 +0530 Message-Id: <20210805083551.234027-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210805083551.234027-1-umang.jain@ideasonboard.com> References: <20210805083551.234027-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer: Fix unused parameter X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hirokazu Honda cameraBuffer function in private constructor is unused. Mark it as such. Fixes: 33dd4fab9d39("libcamera: base: class: Don't pass Extensible pointer to Private constructor") Signed-off-by: Hirokazu Honda Reviewed-by: Umang Jain Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/android/mm/cros_camera_buffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp index 437502fb..e8783ff8 100644 --- a/src/android/mm/cros_camera_buffer.cpp +++ b/src/android/mm/cros_camera_buffer.cpp @@ -44,7 +44,7 @@ private: } mem; }; -CameraBuffer::Private::Private(CameraBuffer *cameraBuffer, +CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer, buffer_handle_t camera3Buffer, [[maybe_unused]] int flags) : handle_(camera3Buffer), numPlanes_(0), valid_(false),