From patchwork Mon Jul 19 10:14:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13042 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 87378C322B for ; Mon, 19 Jul 2021 10:15:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4926B68538; Mon, 19 Jul 2021 12:15:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="oMbR8cJA"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D66D468537 for ; Mon, 19 Jul 2021 12:14:59 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.64]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C2735465; Mon, 19 Jul 2021 12:14:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1626689699; bh=4sONJ6spI0CxKT2VYs23ggHpHMCOr3OPkMGOPft1f8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oMbR8cJAdMTFRN+NfBr/SrSQn67qR9bjoSskG6fdil1vsKVOFHdqTlKguVCk3+NhT LjnsJx6om0YizGgHtj19ZYVHCLq+FAK5MAKGOfns4lb3F3lx6VEf96rkXs/vxH9qgp yod2TcOO7/+y8238rDUWTZTubwX1aQNKzsInlGjE= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Mon, 19 Jul 2021 15:44:37 +0530 Message-Id: <20210719101437.326523-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210719101437.326523-1-umang.jain@ideasonboard.com> References: <20210719101437.326523-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] imx258: Read analog gain register values X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Also copy and tweak imx258_read_reg() to allow signed int values. (These constants are signed ints). --- drivers/media/i2c/imx258.c | 78 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index f86ae18bc104..d029706f4d51 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -21,6 +21,13 @@ #define IMX258_REG_CHIP_ID 0x0016 #define IMX258_CHIP_ID 0x0258 +/* Gain constant registers */ +#define IMX258_REG_GAIN_CAP 0x0080 +#define IMX258_REG_C0 0x008E +#define IMX258_REG_M0 0x008C +#define IMX258_REG_C1 0x0092 +#define IMX258_REG_M1 0x0090 + /* V_TIMING internal */ #define IMX258_VTS_30FPS 0x0c98 #define IMX258_VTS_30FPS_2K 0x0638 @@ -650,6 +657,38 @@ static int imx258_read_reg(struct imx258 *imx258, u16 reg, u32 len, u32 *val) return 0; } +static int imx258_read_reg_signed(struct imx258 *imx258, u16 reg, u32 len, int16_t *val) +{ + struct i2c_client *client = v4l2_get_subdevdata(&imx258->sd); + struct i2c_msg msgs[2]; + u8 addr_buf[2] = { reg >> 8, reg & 0xff }; + u8 data_buf[4] = { 0, }; + int ret; + + if (len > 4) + return -EINVAL; + + /* Write register address */ + msgs[0].addr = client->addr; + msgs[0].flags = 0; + msgs[0].len = ARRAY_SIZE(addr_buf); + msgs[0].buf = addr_buf; + + /* Read data from register */ + msgs[1].addr = client->addr; + msgs[1].flags = I2C_M_RD; + msgs[1].len = len; + msgs[1].buf = &data_buf[4 - len]; + + ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); + if (ret != ARRAY_SIZE(msgs)) + return -EIO; + + *val = get_unaligned_be32(data_buf); + + return 0; +} + /* Write registers up to 2 at a time */ static int imx258_write_reg(struct imx258 *imx258, u16 reg, u32 len, u32 val) { @@ -1055,6 +1094,7 @@ static int imx258_identify_module(struct imx258 *imx258) struct i2c_client *client = v4l2_get_subdevdata(&imx258->sd); int ret; u32 val; + int16_t value; ret = imx258_read_reg(imx258, IMX258_REG_CHIP_ID, IMX258_REG_VALUE_16BIT, &val); @@ -1070,6 +1110,44 @@ static int imx258_identify_module(struct imx258 *imx258) return -EIO; } + // Hijack this to also read analog gain registers and print values + dev_info(&client->dev, "Reading analog gain registers...\n"); + + ret = imx258_read_reg(imx258, IMX258_REG_GAIN_CAP, IMX258_REG_VALUE_16BIT, &val); + if (ret) { + dev_err(&client->dev, "failed to read GAIN_CAP %x\n", + IMX258_REG_GAIN_CAP); + } + dev_info(&client->dev, "Value of analog Gain capability: %d\n", val); + + ret = imx258_read_reg_signed(imx258, IMX258_REG_C0, IMX258_REG_VALUE_16BIT, &value); + if (ret) { + dev_err(&client->dev, "failed to read C0 %x\n", + IMX258_REG_C0); + } + dev_info(&client->dev, "Value of C0: %d\n", value); + + ret = imx258_read_reg_signed(imx258, IMX258_REG_M0, IMX258_REG_VALUE_16BIT, &value); + if (ret) { + dev_err(&client->dev, "failed to read M0 %x\n", + IMX258_REG_M0); + } + dev_info(&client->dev, "Value of M0: %d\n", value); + + ret = imx258_read_reg_signed(imx258, IMX258_REG_C1, IMX258_REG_VALUE_16BIT, &value); + if (ret) { + dev_err(&client->dev, "failed to read C1 %x\n", + IMX258_REG_C1); + } + dev_info(&client->dev, "Value of C1: %d\n", value); + + ret = imx258_read_reg_signed(imx258, IMX258_REG_M1, IMX258_REG_VALUE_16BIT, &value); + if (ret) { + dev_err(&client->dev, "failed to read M1 %x\n", + IMX258_REG_M1); + } + dev_info(&client->dev, "Value of M1: %d\n", value); + return 0; }