From patchwork Thu Jul 15 21:14:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12996 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6D882C322A for ; Thu, 15 Jul 2021 21:15:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2444768580; Thu, 15 Jul 2021 23:15:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Rq0jGcKR"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BDC0468562 for ; Thu, 15 Jul 2021 23:15:12 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AF1B56B for ; Thu, 15 Jul 2021 23:15:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1626383712; bh=JNMwK9ZSYz74XZ/FXU8Sqe7EC2ux5T3ZhU5D9oBlbU4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Rq0jGcKRkZoCbZ+xLe0NjKxhb/z1eQ/YJxubTkYEg+aOSz4ctX5NDMKJyR5hIt2kY rHl/Kse3oIv0nmpEQuIv2iIF1ETWtDSLuxbz3o7AuzBRhpBh9JYwg+DK7noG9o/Fr1 d3pDUMKkTgjeMmEAswu/40/nWOwYVGUH1vEbyvx0= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 16 Jul 2021 00:14:50 +0300 Message-Id: <20210715211459.19373-25-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210715211459.19373-1-laurent.pinchart@ideasonboard.com> References: <20210715211459.19373-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 24/33] cam: Drop unneeded error check and message X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The EventLoop::exec() function returns the exit code of the event loop, not an error status. Drop the corresponding error check and error message. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/cam/main.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cam/main.cpp b/src/cam/main.cpp index 2ef26353e712..19ed9837cf4f 100644 --- a/src/cam/main.cpp +++ b/src/cam/main.cpp @@ -313,9 +313,7 @@ int CamApp::run() if (options_.isSet(OptMonitor)) { std::cout << "Press Ctrl-C to interrupt" << std::endl; - ret = loop_.exec(); - if (ret) - std::cout << "Failed to run monitor loop" << std::endl; + loop_.exec(); } return 0;