From patchwork Mon Jul 12 10:02:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12909 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 65065C3226 for ; Mon, 12 Jul 2021 10:02:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1EB4D68524; Mon, 12 Jul 2021 12:02:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="RNbX5AmQ"; dkim-atps=neutral Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D914E68537 for ; Mon, 12 Jul 2021 12:02:21 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id k32so7791495wms.4 for ; Mon, 12 Jul 2021 03:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JfVlZgifnrAPHzprhAfOgQPbEe41tKFlQcQqQlEMu0M=; b=RNbX5AmQ+a8w6fYoLVsQbAeMBsrJqSk4KGIglmpM7j0KAeKVEjYIX5kuMq0UOq1+p0 yZhP2JzxlSam76LGOG9O4rC/wAdQuILtn06p+0Qlcj5P2goeqmyu1TeRUWJ8j6LLiTz3 xRwZv0G9n7il1oV8wR0xCYSfjRFpgM9HjvwKRNGrHiruIctPbpePfZoXmzMzwQtGMgy0 YA8FxBDRQn7XqXOqHJ4sdvnD3SEDY+QZqfLwAgPn4KN0RIQxgHxUg8i/xvkxKBUY2swo FvEv1vcl30d8sjjiVSSwavx23ck0/8N7pvfcWHdt2XBJfokJ86olxUMskDZf/dXwq5UV /Zkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JfVlZgifnrAPHzprhAfOgQPbEe41tKFlQcQqQlEMu0M=; b=MZ9fam+Ozfed792Nxt18fW0KyayA5W7EHIBIQNYT6C0Y5yMgsrxxJqbMQl+2Bx+J0s gY3aY2qXc+jOAJSZBbrPbhtsRSR8rfVB172VoYA/KvOmrecYItLwKnjYyhaC+g7Pow2c TtfOJUpyzYEB349PB0vgFNSEltYzDrpLvf4a3nv1lYyjRhptV/FEx9zCOCx8XQjMxIQe LEGpGWkWq15O8apgt2JYOgnPuuymdAN3wLH4OPuHwNUtsiq0GyzmLCXH+uDMAR7/v7IM 0aZIt1dUAmqHfGgordZbcDggLhvgJhwp+WKXyHU5WM6M/jghlgchQRRwwhfUA6NXSP3A CZDg== X-Gm-Message-State: AOAM5332E7aEkD0UJB5jP7BR3n5F9EgJ69N7iPZm0tBXR4yNd+FRWgRQ leDDQv9Uveek0fqrJfvq+KSh0O/nzEI/iw== X-Google-Smtp-Source: ABdhPJzm9wIfhdSwtW/PXbUlWj8e+fGRilbgHUAhqPsPLyU6eA+RciCRAdDynFYPHNkmHiHxBA0DnQ== X-Received: by 2002:a1c:1d8e:: with SMTP id d136mr36956864wmd.52.1626084141450; Mon, 12 Jul 2021 03:02:21 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:3395:5e50:10bb:f8fd]) by smtp.gmail.com with ESMTPSA id b16sm14249941wrs.51.2021.07.12.03.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 03:02:20 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 12 Jul 2021 11:02:09 +0100 Message-Id: <20210712100209.447893-9-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210712100209.447893-1-naush@raspberrypi.com> References: <20210712100209.447893-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v7 8/8] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 8fb98a49da63..1dd7fd68c3e9 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);