From patchwork Mon Jul 12 10:02:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12902 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0F9B8C3224 for ; Mon, 12 Jul 2021 10:02:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9AC986852C; Mon, 12 Jul 2021 12:02:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Hd7M+Cel"; dkim-atps=neutral Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C36168521 for ; Mon, 12 Jul 2021 12:02:16 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id v5so24795815wrt.3 for ; Mon, 12 Jul 2021 03:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IF2nPnuOcRtGtByOSMQln8DsOJyZiq6YxqgDrJr80Sw=; b=Hd7M+Cel46Y/Z9W9VMlzCNi7R/MwWz3EbWy5c0ssJJtSNzWKvTzngiXLNsx+PhuOI6 ZcLf74B8LKDDNmolYfXh9v9fdkhGcpfPirs08bmiOnzw8CsBjHNwqjYUv61JsRBapbja kme+axAXQlD16pincDF1TNsBwkuNE8t65vEikXKy5Cb/VrRiWqr2cZQ4CvzpVEMo69Zk MhTdozFwT4fwV9j34A6InAn1DXouL9pvAPOfwc8yAdIAwVxAVf3uasK06+HB1xyna3B1 bOREUvWxYdYAPXLOFGCgjNkEAyFBCa6kuuSDFWRihcspx1IQJtCK91hcnj9jrjMvbjXc svig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IF2nPnuOcRtGtByOSMQln8DsOJyZiq6YxqgDrJr80Sw=; b=a4amdq+sd/OOPGKnJVVnzX1cPlE8r/3wKCBcfO44D20WnloJtl/P1VnRQ8v00Il3l2 wrG+JS6fEH4o9ZfiI84sYccMS8tjUW/5sdsNzuKED1ntYVbCYE1gsQ39rJR+MrhhGDXx w2o0dUlPzRP0oxnOXPK3XpUjcZHVLO1632c60J2duXXkE/3PNORYNMl2Xai6SFLjUkJZ mk2ineyldOH55cqilgm2I8Gv01qMytAgsgtS+23g6G5PWx6W5ojtUxOQiZkRzlfdOrH/ 7cMF/s2Fc+aCv2mj9ewO8xr/bOU0TE3G+uW7I6BYvCRZ8HGclGkxm4XL88DaoA/vaR9C DKYQ== X-Gm-Message-State: AOAM532aGCC5OyKywxDX25VtlTzaxbv/RA1OLDIpXf+1AZz8d1elNL0a aSNK6TEuTEBjqZdLmqzlA6hnzBi4u2CAyQ== X-Google-Smtp-Source: ABdhPJxh2ABBDCDdkI5ap7CL/OAW5BBPCW/ZqgaN1WtKlZp0lJrXwAEiOFI16OEKqvq84yDlux3PNA== X-Received: by 2002:adf:f907:: with SMTP id b7mr57650785wrr.357.1626084135872; Mon, 12 Jul 2021 03:02:15 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:3395:5e50:10bb:f8fd]) by smtp.gmail.com with ESMTPSA id b16sm14249941wrs.51.2021.07.12.03.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 03:02:15 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 12 Jul 2021 11:02:02 +0100 Message-Id: <20210712100209.447893-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210712100209.447893-1-naush@raspberrypi.com> References: <20210712100209.447893-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v7 1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This header file is no longer C compatible, so remove the extern "C" declaration. Replace C++ style comments with C style based on libcamera guidelines. There are no functional changes in this commit. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- .../raspberrypi/controller/device_status.h | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h index f74235248b12..733378dbfa27 100644 --- a/src/ipa/raspberrypi/controller/device_status.h +++ b/src/ipa/raspberrypi/controller/device_status.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: BSD-2-Clause */ /* - * Copyright (C) 2019, Raspberry Pi (Trading) Limited + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited * * device_status.h - device (image sensor) status */ @@ -8,25 +8,19 @@ #include -// Definition of "device metadata" which stores things like shutter time and -// analogue gain that downstream control algorithms will want to know. - -#ifdef __cplusplus -extern "C" { -#endif +/* + * Definition of "device metadata" which stores things like shutter time and + * analogue gain that downstream control algorithms will want to know. + */ struct DeviceStatus { - // time shutter is open + /* time shutter is open */ libcamera::utils::Duration shutter_speed; double analogue_gain; - // 1.0/distance-in-metres, or 0 if unknown + /* 1.0/distance-in-metres, or 0 if unknown */ double lens_position; - // 1/f so that brightness quadruples when this doubles, or 0 if unknown + /* 1/f so that brightness quadruples when this doubles, or 0 if unknown */ double aperture; - // proportional to brightness with 0 = no flash, 1 = maximum flash + /* proportional to brightness with 0 = no flash, 1 = maximum flash */ double flash_intensity; }; - -#ifdef __cplusplus -} -#endif