From patchwork Sun Jul 11 23:15:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12898 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 240E5BD794 for ; Sun, 11 Jul 2021 23:16:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 01C9268532; Mon, 12 Jul 2021 01:16:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sEvUOinP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CC5A68521 for ; Mon, 12 Jul 2021 01:16:37 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A0C6255 for ; Mon, 12 Jul 2021 01:16:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1626045397; bh=AKBanrAdVydDPTr/wUG2A8XjnWG996WDcV1XgyeSvSw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=sEvUOinP4vQEDpqy9n8+xJ+ktYWZ3SmI/MaiwbZ5T0cPmiSBvikplfXSBpTH0YFsx 2iN5nxU2WwXywp7sJW+/wcqWZ0+tVhLZ6mlrL1e7TN2j6HO077FMS6mRiPzp0iumG9 YZJnMDWMk9oN6AQwNgJ3YfiRYr2vA0vRs5kMw68s= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Mon, 12 Jul 2021 02:15:45 +0300 Message-Id: <20210711231547.19664-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210711231547.19664-1-laurent.pinchart@ideasonboard.com> References: <20210711231547.19664-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA module min/max version check X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPAManager::createIPA() function has its minVersion and maxVersion parameters inverted. This doesn't cause any issue at the moment as both the minimum and maximum version are set to 1 by all callers, but it's still a bug. Fix it. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Paul Elder --- include/libcamera/internal/ipa_manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h index 34224e330da7..42201839901b 100644 --- a/include/libcamera/internal/ipa_manager.h +++ b/include/libcamera/internal/ipa_manager.h @@ -31,8 +31,8 @@ public: template static std::unique_ptr createIPA(PipelineHandler *pipe, - uint32_t maxVersion, - uint32_t minVersion) + uint32_t minVersion, + uint32_t maxVersion) { IPAModule *m = nullptr;