From patchwork Fri Jul 9 14:58:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12891 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1E07CC3226 for ; Fri, 9 Jul 2021 14:58:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C5DFC68528; Fri, 9 Jul 2021 16:58:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="VVEq0Kl0"; dkim-atps=neutral Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C2B768528 for ; Fri, 9 Jul 2021 16:58:36 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id g16so2638698wrw.5 for ; Fri, 09 Jul 2021 07:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+/4A6ABHPnLQLSLzSzJ8J1XyM12VeDFiiq0NwDb/Dis=; b=VVEq0Kl035cb/PKDl95rMiTcUW5hOukS7fXRNzN2kyY8If6rkWT0WABNw10nIysNSl qvokmwzEpKumo2TfzzsAjV5ulo7fLcCipRnzhftOpUgdU1O+xugUqTVD67GQ3SL4vqqT 35iOI1+1+zbqrPNP5EKSHAd3fyqgvjQvLLR/axkR64/2aZCxC3W/VkOpuQduu9U5zo9T XnYdJk6mpcg8plIB7mLqZRioo8kz+qQ3ZtxITBxO9mU9bca7Gek0MFnoxssik4zofByB Rm600ZORmdIw7J72cXI5vsJIr41og6C6nA3RQ+eOrKLOjuAezp/GW8e9kM69fkWfiHTN HcjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+/4A6ABHPnLQLSLzSzJ8J1XyM12VeDFiiq0NwDb/Dis=; b=NiGh16yXrKwAXlKF9r4xXQI41qL5/t1SQHKTtFQYgTCiSVPDj8xt4uX2GGBa8zRKVb YkIScXREL8creW+kWK1Di1fdUE33lQmGJnRZzO2tkeai7e5pOgNimDduCN8PmTxYuYhk 5sBge2g7YDpBSDCD1Vr4pp6yfPGRXqT04+tRElyO42oUgv1Uuo06SuFp3I9+D+WwIbBA UFE33iXccfGrUIVNyzweVULgM/ZOSdLl6vyD8FH+dQ1/UvrVB3g8oi0LNUyboZh9e94f tz0CAgdLssjMdJiheuwKB+BPm607wE8Z58d2JoRn90/Od+X5s5OQIDi/urSE8hMQWqnd S8tA== X-Gm-Message-State: AOAM532M2ev3CDZC5s/OtPjHa74bpa4i5vePPRLvoovWbMWKK9jC6v3F 9xXWhmjnpUuQB1rsyOcLPvkLI7+lQFgVtQ== X-Google-Smtp-Source: ABdhPJzblk4kkFk0g2Ovg2fiFCSm37oEyMuyM9TS0Mds++Hke4n+ua5I+o9WNreH8KAKOiV5yqV9ng== X-Received: by 2002:a5d:56d0:: with SMTP id m16mr42688149wrw.26.1625842715818; Fri, 09 Jul 2021 07:58:35 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:35c2:26d3:e217:4410]) by smtp.gmail.com with ESMTPSA id c2sm1480995wrn.28.2021.07.09.07.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 07:58:35 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 9 Jul 2021 15:58:25 +0100 Message-Id: <20210709145825.2943443-9-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210709145825.2943443-1-naush@raspberrypi.com> References: <20210709145825.2943443-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 8/8] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 8fb98a49da63..1dd7fd68c3e9 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);