From patchwork Fri Jul 9 14:58:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12884 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 36652C3225 for ; Fri, 9 Jul 2021 14:58:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E53C36851B; Fri, 9 Jul 2021 16:58:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="CrxyJf3U"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DF1A9684E7 for ; Fri, 9 Jul 2021 16:58:30 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id t14-20020a05600c198eb029020c8aac53d4so26039070wmq.1 for ; Fri, 09 Jul 2021 07:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dNPy1AuK4kcuuK0B4jDCWxmKmOZ6QX0jJpC6NtzaGA4=; b=CrxyJf3U3yW2/kAhIuYrLYOgu2VsaEcUwOmfkyV/SGGgDzYfOosBdn8pGCUMKEfs5f J0sQsYHSestTAQb1wb096leGQfpWPUDk5tVLAqry+ILxHmkgykMuDuX2EnjceX2Pjecb TzX5xcodyCwa7swVNREaS9Tutvb+Dz8gXZUIpz+bmeWVuJbqv3y+wbiQX11EULReRj6U 1cfPCmxtutzpeaKw0Eez4WvNBv31I6BTI3QngtmORO5f4FqPPQ1vrBAWuMVJiaDwJmrt vFg0GesTjbcEUR95WrX78h9O03jlXKBnXPtIVlbQ3g6XeVUjrohVwproU8eukD5guFvA o6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dNPy1AuK4kcuuK0B4jDCWxmKmOZ6QX0jJpC6NtzaGA4=; b=MFe0ruC6KQLCk5Et93mI1EAVsAYNbgcflKyKQcZOoairC15RrbIE19BCFN5LfUnmNh JZKhy16OtSRXYQsunnI6KcXoOdcX6pBPqfl+uGivBBA2VD2MgjgFkX0FRP6j01LVHN6w q4YHeofby7HkURpVAy2qoSJ+GOBuklN8Gj5EXWC4lOYIQf2X7qORvjY/GTSSgDyT4zp/ aagixZOYuDE/4n2XEUtbbFxg5BN+D9QjbiL0RyjYPLI8tPq8q1v0kBXpaOADGj73b0JX SFkD/ZaZdxwlNJUd99z3Qk073xfv8+Y3JsPJdGlhy6OguEgrko+QaiFesAIkYMFtnuUd zHkQ== X-Gm-Message-State: AOAM532/VG3ltIPEAlIOngLFWS0fFuZb9XB5SBwSK6fpblUo/hzwP4XB 2ymAbbRX6U4P7YgrRDoTFLD6+PB6iyz+dQ== X-Google-Smtp-Source: ABdhPJxcHpARqbVsoFLEvfPMH6XiJU8f5ltOZFAQ+t8Aga+hKVQIH9rhEbnuRwTaxg9B/PZce4Cs2w== X-Received: by 2002:a7b:c258:: with SMTP id b24mr12645737wmj.122.1625842710397; Fri, 09 Jul 2021 07:58:30 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:35c2:26d3:e217:4410]) by smtp.gmail.com with ESMTPSA id c2sm1480995wrn.28.2021.07.09.07.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 07:58:29 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 9 Jul 2021 15:58:18 +0100 Message-Id: <20210709145825.2943443-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210709145825.2943443-1-naush@raspberrypi.com> References: <20210709145825.2943443-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This header file is no longer C compatible, so remove the extern "C" declaration. Replace C++ style comments with C style based on libcamera guidelines. There are no functional changes in this commit. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- .../raspberrypi/controller/device_status.h | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h index f74235248b12..733378dbfa27 100644 --- a/src/ipa/raspberrypi/controller/device_status.h +++ b/src/ipa/raspberrypi/controller/device_status.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: BSD-2-Clause */ /* - * Copyright (C) 2019, Raspberry Pi (Trading) Limited + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited * * device_status.h - device (image sensor) status */ @@ -8,25 +8,19 @@ #include -// Definition of "device metadata" which stores things like shutter time and -// analogue gain that downstream control algorithms will want to know. - -#ifdef __cplusplus -extern "C" { -#endif +/* + * Definition of "device metadata" which stores things like shutter time and + * analogue gain that downstream control algorithms will want to know. + */ struct DeviceStatus { - // time shutter is open + /* time shutter is open */ libcamera::utils::Duration shutter_speed; double analogue_gain; - // 1.0/distance-in-metres, or 0 if unknown + /* 1.0/distance-in-metres, or 0 if unknown */ double lens_position; - // 1/f so that brightness quadruples when this doubles, or 0 if unknown + /* 1/f so that brightness quadruples when this doubles, or 0 if unknown */ double aperture; - // proportional to brightness with 0 = no flash, 1 = maximum flash + /* proportional to brightness with 0 = no flash, 1 = maximum flash */ double flash_intensity; }; - -#ifdef __cplusplus -} -#endif