From patchwork Fri Jul 9 11:47:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12881 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CD2F0BD794 for ; Fri, 9 Jul 2021 11:47:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 565506851B; Fri, 9 Jul 2021 13:47:53 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pr52KtmF"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F8C9605AC for ; Fri, 9 Jul 2021 13:47:52 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [IPv6:2405:204:8084:161d:f4be:7125:3161:2a88]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AE165E7; Fri, 9 Jul 2021 13:47:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625831271; bh=fnn6lGVKvm3aK7GoZx22Fz7to/hbLivZFr9ppoxjRgs=; h=From:To:Cc:Subject:Date:From; b=pr52KtmFPg5saDe3I169CssG/FSig7Ed0rQDwh5az+iwCU/aB/QSDEzuhcMCX6Je3 LnYfxd2QD2GUR6Z2g8KRZDNzGPHBtqRB3dDSiuQ/fxZDXalk9kYWNFD2g7xj4+dlNN 1Z0VOhqjgEsVLTu6I6xtJHrum0ahx4SpM2ofJsiI= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Fri, 9 Jul 2021 17:17:35 +0530 Message-Id: <20210709114736.875760-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] libcamera: v4l2_videodevice: Correctly populate V4L2BufferCache cache X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Populating of the cache in V4L2BufferCache's constructor is incorrect. The cache_ in V4L2BufferCache is a vector of struct Entry, whose constructor takes the form: Entry(bool free, uint64_t lastUsed, const FrameBuffer &buffer) Passing a FrameBuffer::Plane vector via buffer->planes() is incorrect. Rectify by passing in a Framebuffer reference. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/v4l2_videodevice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index 3d2d99b4..da2af6a1 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -183,7 +183,7 @@ V4L2BufferCache::V4L2BufferCache(const std::vector> for (const std::unique_ptr &buffer : buffers) cache_.emplace_back(true, lastUsedCounter_.fetch_add(1, std::memory_order_acq_rel), - buffer->planes()); + *buffer.get()); } V4L2BufferCache::~V4L2BufferCache()