From patchwork Fri Jul 9 09:56:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12879 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 55EC2BD794 for ; Fri, 9 Jul 2021 09:56:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0A1FC68526; Fri, 9 Jul 2021 11:56:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="gqU6qDiR"; dkim-atps=neutral Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 875166851F for ; Fri, 9 Jul 2021 11:56:54 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id k4so5065026wrc.8 for ; Fri, 09 Jul 2021 02:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=; b=gqU6qDiRISaxcYhJz97vNrv7uk2z+Ircv2wB+sLUYJcfwb92aTLX+I85lr+XWA+lIY N6z3f6wKi2ETJN0tZ/H4R6tK8V1XfEziMakzJjgNkOjQMTsCLzbPrvxU1IvEvtdehnbB xkJKr7xY1W12Nhphs79FwQxb9NMS05uIVPwBtEmpb3Q2Ll93q+lbTODjdruqveKMGC9n 0I8xlha828fJP2RIBlMoia04j3aNXAVvtgtuQylhOu04G11t5EeQ3c1k63AQte5hoPmU hFi1/gku8I1a9JWlSJRcZ8LAimMXW4eBbVvHlpkZuYq1ZYWD0YfCyu6owAE2siUtrS3U irww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=; b=tDee+8ZS7FTpkSzluHFzSuZDdkzrSITBLV/4fdxG4qktjxS6Aod7fWARsje4IuoLHm 3LmiAA3bZds9ssNSWXeh7rQtvTY713MeiblBpOa95iKOAG1axkILORD0qjtfYMdPUmGA q1TkHWmxSL9SB/H0FtXoHHtdvnT3BeBwIjkWXr2CW34OThkVjn67g7OO85r+bwEoqrMY bp0Y0QXWVYTfEM9XU6hXYCmDev3YBx7OJWlP9jvZpVYFIO4RH9ITEeJKpr+tQ2hWta10 krBIZCcG/7KqFEo2DuCOIMhpeVQC93vJi+ZK7oUMENaV5GdnQ0KN5xNrqtLupVYs9qBb 4USw== X-Gm-Message-State: AOAM5315D88cppwzvfLe8gNU+1eYYfGGXrDLxMiOzq20cUOqZsAHmdRj KfDM88Gyc75l/aSPC1zKRY+Iv0URbrDm6g== X-Google-Smtp-Source: ABdhPJww0ry8sMh7P1mzcejttvoMqBNhidUdoK7OmcFOKYOg40HsqoMTnv6PNnsH2HA07sa5gAbarw== X-Received: by 2002:adf:f848:: with SMTP id d8mr33853855wrq.308.1625824614111; Fri, 09 Jul 2021 02:56:54 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:35c2:26d3:e217:4410]) by smtp.gmail.com with ESMTPSA id b16sm1599014wrw.46.2021.07.09.02.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 02:56:53 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 9 Jul 2021 10:56:38 +0100 Message-Id: <20210709095638.2801713-8-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210709095638.2801713-1-naush@raspberrypi.com> References: <20210709095638.2801713-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 8/8] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 8fb98a49da63..1dd7fd68c3e9 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);