From patchwork Fri Jul 9 09:56:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12872 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F3B6ABD794 for ; Fri, 9 Jul 2021 09:56:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2778468524; Fri, 9 Jul 2021 11:56:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="NgHRY8Ki"; dkim-atps=neutral Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 776B9684F3 for ; Fri, 9 Jul 2021 11:56:49 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id m2so340643wrq.2 for ; Fri, 09 Jul 2021 02:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=; b=NgHRY8KitMyYbpbIi8XJF8LYVbTwoKH4gJRZT6+X4QSc8hYncc7nbbiD0ywhX7jhvc NBS/cBaDP+rPGpM9fEJve8awsKD5p3Kq5flpNnxjoNN/YON3M+tg495OfYTRnLccMVCZ QEWDOz8Lc7beLsOIppD2vGbSHSHPNDmJuTNkFBoxjXVSUH3dUpODEdDNm6pLJnmtHOoC iSxq1wdoTmF3FRl2Qcd80j5IgoEASMpdG6vHYFOf7TvZdo8kC94iRPubUNTYqcbW2x3B barY32VLQ1dczRLTeVKNBJGuxt9WFNxyHw8aHj3MP7MhHpzLnSCySIPtyuEZ8kCWRRar XoAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=; b=PYNxUk9qFq6V3DzM4GWO8pEj8gnPkJstgU0wHlWQYZ1erQ2s2pOXcDznDXd22vuEh4 NbpwqVOqkfqnW36jiN4he8n7JvmJDr7vLZEpeZ+4qC4C/vZkR/aGDRFDoiHoCmI0/YBk hKMuHWaevvhcgvYyjHLvx4KIdhS329NvXWZQMxtnMxn/m2Xj5Or8OQvaP4qrZOkPDeoL qxLwEFZ71oY9KqfDvwT35AnvuP1sPEBpRqNit0W8aLmW9dbVwRzTjmKifIBxGTOVW9f+ NcYcp7WIUWX/Iy4NtfSnO4QLNfeV1bsUvB0ED1Ve/ENcrk8/0/IXu9nooRbFekjBbHMg uOBA== X-Gm-Message-State: AOAM530CYly9/NXC6/t8GhHXxftNeajFeAYQezITnsPoBmORJCOnGdQq soRv1AkdsD3kZOIShHcx1YuH2cdplWKjjw== X-Google-Smtp-Source: ABdhPJxWY0jlPQD5zdnL4RkHLyCj+Atst9N3qvHxsHuXxPgqYravg0NludQ7xMyfKAJ5dEaZk77y2w== X-Received: by 2002:a5d:64e4:: with SMTP id g4mr33690572wri.377.1625824608762; Fri, 09 Jul 2021 02:56:48 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:35c2:26d3:e217:4410]) by smtp.gmail.com with ESMTPSA id b16sm1599014wrw.46.2021.07.09.02.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 02:56:48 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 9 Jul 2021 10:56:31 +0100 Message-Id: <20210709095638.2801713-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This header file is no longer C compatible, so remove the extern "C" declaration. Replace C++ style comments with C style based on libcamera guidelines. There are no functional changes in this commit. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Kieran Bingham --- .../raspberrypi/controller/device_status.h | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h index f74235248b12..733378dbfa27 100644 --- a/src/ipa/raspberrypi/controller/device_status.h +++ b/src/ipa/raspberrypi/controller/device_status.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: BSD-2-Clause */ /* - * Copyright (C) 2019, Raspberry Pi (Trading) Limited + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited * * device_status.h - device (image sensor) status */ @@ -8,25 +8,19 @@ #include -// Definition of "device metadata" which stores things like shutter time and -// analogue gain that downstream control algorithms will want to know. - -#ifdef __cplusplus -extern "C" { -#endif +/* + * Definition of "device metadata" which stores things like shutter time and + * analogue gain that downstream control algorithms will want to know. + */ struct DeviceStatus { - // time shutter is open + /* time shutter is open */ libcamera::utils::Duration shutter_speed; double analogue_gain; - // 1.0/distance-in-metres, or 0 if unknown + /* 1.0/distance-in-metres, or 0 if unknown */ double lens_position; - // 1/f so that brightness quadruples when this doubles, or 0 if unknown + /* 1/f so that brightness quadruples when this doubles, or 0 if unknown */ double aperture; - // proportional to brightness with 0 = no flash, 1 = maximum flash + /* proportional to brightness with 0 = no flash, 1 = maximum flash */ double flash_intensity; }; - -#ifdef __cplusplus -} -#endif