From patchwork Wed Jul 7 09:48:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12852 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6AAD3C3225 for ; Wed, 7 Jul 2021 09:48:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 272EC6851F; Wed, 7 Jul 2021 11:48:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="dN9i+D6R"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E3386851B for ; Wed, 7 Jul 2021 11:48:23 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id t6so2296264wrm.9 for ; Wed, 07 Jul 2021 02:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=; b=dN9i+D6RKPPLxUCHuh2KwqgOie/w5yIdl7EpIw3SR+PebDSbx+VmMsJygl479OGqqQ rM/7huivwoK+IEQn0n3DdDqdfjLMtLIoRmDINUvTIugOlCWgGB9Jc+qa29kVUOm+aNUb pXixzJ7/JfHA29XqNOPJTkgxG4Zl7wMFWBY5DqOxn4nk3MrcurmEOBc2mkN0crwU+hoM tq0wFIDsMDDI3+Fjc5h1njmw89ec+F/iJZ215gy5/EmtOn41pbsuNtCVYbh+LQ3rmFRi Q8n2cujAXDZBCMW2x/gQB6u7m2zlR7QFILaEp3iyzMoleOIE6CLoVPTJzY2cGGWqK8cF STbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=; b=ugAKTymgDU1Hdy7ztsUQar6W1h2KVZPHagFM/DXk/5kaNpbNBdyJHrp6l0lZUwXqY4 uT01jG1cAaz0UKucnv6krdM+XSVTPNht81T7s37TWpvKxnrQFV2kXPCru3ReW6GrAQGB j9ojGjltDwbEkf0YSAqolAHOtmb1ZQSv2WICQWsZikqEiz7ubAYUfuWantbUCe9k4W67 3ZkI7W/gP5IF+goL+nIhpimg5qIGYzVGOFyycUMJn+WNXoBbTy6qdFPY+s5SrTauLPvk QS52wWHN9O6JR+YFnH8D27axr8DRnk2W2TkZL9T65Vy508gff/lpLIZWTax1KFkYkt/I 127g== X-Gm-Message-State: AOAM533YnnOYnaQ3q1Dstn/orXaIVSxueFCXbXBtglhzc1+W62A7sFAY wL6XW0f0mcuEl+qR1ZhU86PhLs+kLpUJPQ== X-Google-Smtp-Source: ABdhPJwWQn7vWf9bCOMe3q9RJfCenKC6GFuzpqwNghALd8ZI8dl8IX3G3vRNMurIhfMtC+zbzKA/HQ== X-Received: by 2002:a05:6000:1b8c:: with SMTP id r12mr18642355wru.427.1625651303135; Wed, 07 Jul 2021 02:48:23 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:f800:302e:bf7e:a06b]) by smtp.gmail.com with ESMTPSA id r16sm23377836wrx.63.2021.07.07.02.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 02:48:22 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 7 Jul 2021 10:48:15 +0100 Message-Id: <20210707094815.1500917-9-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707094815.1500917-1-naush@raspberrypi.com> References: <20210707094815.1500917-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 8/8] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 8fb98a49da63..1dd7fd68c3e9 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);