From patchwork Wed Jul 7 09:48:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12845 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 40C34C3224 for ; Wed, 7 Jul 2021 09:48:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 676C06851F; Wed, 7 Jul 2021 11:48:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Oyzw3sYx"; dkim-atps=neutral Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E799F68506 for ; Wed, 7 Jul 2021 11:48:18 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id p8so2341992wrr.1 for ; Wed, 07 Jul 2021 02:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=; b=Oyzw3sYxgKbdok7MiAIUVoEnHh+mZxYtYeEdu6WSSjaUL3CPFO/g5VzDd4SvTMQKnn A670L463l9f+1Oc0/fzO+IE+Bgd1vMKNAYJc8st6S1WA2bLvutM4ehpAXZlDl9AAQEfv UPiM3ze1O7QwW0zN35H9okldotW+2Vltxd8jFsA/91qdw589k4IFBkynTHDOhD2PbD1K jgaL3Sf5lP7nkibHptWEYJS1gbynLmOimkgKv+z9xfgpsZmf0vg8iKzE7xJy7zG/3Ily q5G+jj8O7jKawdQjGe+3xhxxxuZidDBg7/LcUfKSkUC3aAnJGkipuBh5u2hWsUU1ky1E lNkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=; b=VaQbTEzd254iEdPyV07AfVbOA3khy9Rvg8Uoy98MrBfWWGEuOk5OI8IK/HUgHS61ks kk3eN9yXxhHgKRAUCu4Umb9fHJtkzoh5GHnh1Ed6+P0DrVWmOjffNJB45jJcUshINUAl UQnCZq8FdRPlSFVxeHhVX6rjf5HSjmnuUVVjAM8YjdCFFph+8O23LEl3TBs5Gjp+0xnW /q1zsYW92A3Ms4pRMLona1tv/HoXIp1cbRDaiZmGgd5Zznv5gveO+pQXp/r3v9lu81fw vSQtyE1tYG6CCV8MG1hP6a5Gi8BIs1at5yOQzOSPHpMEgSwbhXZi82LM0+540swiJyDx mTUQ== X-Gm-Message-State: AOAM530ro9LWZ56N2vVlZR8EY+tDEVJoj5RplvGeiPmkwHqKQkqSfbos BMCis4D0X3PtV1fj+hgMmYquWWoo9Ikqgw== X-Google-Smtp-Source: ABdhPJzbs6RMRuDkjYC+TR14J2NBtI2j8cwWuGE+0l6V+WLHKyCp8qFl9MQIHG657uPwPOygayRukg== X-Received: by 2002:adf:d232:: with SMTP id k18mr15789851wrh.35.1625651298458; Wed, 07 Jul 2021 02:48:18 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:f800:302e:bf7e:a06b]) by smtp.gmail.com with ESMTPSA id r16sm23377836wrx.63.2021.07.07.02.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 02:48:17 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 7 Jul 2021 10:48:08 +0100 Message-Id: <20210707094815.1500917-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707094815.1500917-1-naush@raspberrypi.com> References: <20210707094815.1500917-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This header file is no longer C compatible, so remove the extern "C" declaration. Replace C++ style comments with C style based on libcamera guidelines. There are no functional changes in this commit. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman --- .../raspberrypi/controller/device_status.h | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h index f74235248b12..733378dbfa27 100644 --- a/src/ipa/raspberrypi/controller/device_status.h +++ b/src/ipa/raspberrypi/controller/device_status.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: BSD-2-Clause */ /* - * Copyright (C) 2019, Raspberry Pi (Trading) Limited + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited * * device_status.h - device (image sensor) status */ @@ -8,25 +8,19 @@ #include -// Definition of "device metadata" which stores things like shutter time and -// analogue gain that downstream control algorithms will want to know. - -#ifdef __cplusplus -extern "C" { -#endif +/* + * Definition of "device metadata" which stores things like shutter time and + * analogue gain that downstream control algorithms will want to know. + */ struct DeviceStatus { - // time shutter is open + /* time shutter is open */ libcamera::utils::Duration shutter_speed; double analogue_gain; - // 1.0/distance-in-metres, or 0 if unknown + /* 1.0/distance-in-metres, or 0 if unknown */ double lens_position; - // 1/f so that brightness quadruples when this doubles, or 0 if unknown + /* 1/f so that brightness quadruples when this doubles, or 0 if unknown */ double aperture; - // proportional to brightness with 0 = no flash, 1 = maximum flash + /* proportional to brightness with 0 = no flash, 1 = maximum flash */ double flash_intensity; }; - -#ifdef __cplusplus -} -#endif