From patchwork Sun Jul 4 13:05:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12800 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0F2CDC0100 for ; Sun, 4 Jul 2021 13:06:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 51CC768501; Sun, 4 Jul 2021 15:06:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ukhdmoq/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C4E3684E4 for ; Sun, 4 Jul 2021 15:06:34 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BA6B1E7; Sun, 4 Jul 2021 15:06:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625403993; bh=qF+jQ/+4aty7vKBmagB5iW7okG7YZJgVbIWRDHBQmVs=; h=From:To:Cc:Subject:Date:From; b=ukhdmoq/ZMHKE1uhj7wufmnpr0FHtZaLgbl5nTomZZpc24DgDjK6hRYqUGfUMKJ8q m0v8BzHuzHurdQLIlMX72ynHNrq52DeFdan+cuHRvLgWA+gg6saI9rh83xJ+xRygqo YElsbbC9VKGt5SyqFkI3B5mL9g53dAZgjB+nCXng= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sun, 4 Jul 2021 16:05:46 +0300 Message-Id: <20210704130546.21396-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: transform: Document Transform enumerators as such X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Due to a bug in Doxygen that didn't properly handle enum class enumerators when defined in a namespace, the Transform enumerators were documented with free-formed text. The issue has been fixed in Doxygen commit 309b397be106 ("issue #8281: Out-of-line documentation of scoped enums in the same namespace"). We can now fix the documentation. Signed-off-by: Laurent Pinchart Reviewed-by: David Plowman --- src/libcamera/transform.cpp | 38 ++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp index f3e37f313041..99a043ba14d3 100644 --- a/src/libcamera/transform.cpp +++ b/src/libcamera/transform.cpp @@ -43,7 +43,15 @@ namespace libcamera { * couple of them have additional synonyms for convenience). We illustrate each * with its nominal effect on a rectangle with vertices labelled A, B, C and D. * - * **Identity** + * \sa https://en.wikipedia.org/wiki/Examples_of_groups#dihedral_group_of_order_8 + * + * The set of 2D plane transforms is also known as the symmetry group of a + * square, described in the link. Note that the group can be generated by + * only 2 elements (the horizontal flip and a 90 degree rotation, for + * example), however, the encoding used here makes the presence of the vertical + * flip explicit. + * + * \var Transform::Identity * * Identity transform. ~~~ @@ -53,11 +61,11 @@ Input image | | goes to output image | | ~~~ * Numeric value: 0 (no bits set). * - * **Rot0** + * \var Transform::Rot0 * - * Synonym for `Identity` (zero degree rotation). + * Synonym for Transform::Identity (zero degree rotation). * - * **HFlip** + * \var Transform::HFlip * * Horizontal flip. ~~~ @@ -67,7 +75,7 @@ Input image | | goes to output image | | ~~~ * Numeric value: 1 (horizontal flip bit set only). * - * **VFlip** + * \var Transform::VFlip * * Vertical flip. ~~~ @@ -77,7 +85,7 @@ Input image | | goes to output image | | ~~~ * Numeric value: 2 (vertical flip bit set only). * - * **HVFlip** + * \var Transform::HVFlip * * Horizontal and vertical flip (identical to a 180 degree rotation). ~~~ @@ -87,11 +95,11 @@ Input image | | goes to output image | | ~~~ * Numeric value: 3 (horizontal and vertical flip bits set). * - * **Rot180** + * \var Transform::Rot180 * * Synonym for `HVFlip` (180 degree rotation). * - * **Transpose** + * \var Transform::Transpose * * Transpose (about the main diagonal). ~~~ @@ -101,7 +109,7 @@ Input image | | goes to output image | | ~~~ * Numeric value: 4 (transpose bit set only). * - * **Rot270** + * \var Transform::Rot270 * * Rotation by 270 degrees clockwise (90 degrees anticlockwise). ~~~ @@ -111,7 +119,7 @@ Input image | | goes to output image | | ~~~ * Numeric value: 5 (transpose and horizontal flip bits set). * - * **Rot90** + * \var Transform::Rot90 * * Rotation by 90 degrees clockwise (270 degrees anticlockwise). ~~~ @@ -121,7 +129,7 @@ Input image | | goes to output image | | ~~~ * Numeric value: 6 (transpose and vertical flip bits set). * - * **Rot180Transpose** + * \var Transform::Rot180Transpose * * Rotation by 180 degrees followed by transpose (alternatively, transposition * about the "opposite diagonal"). @@ -131,14 +139,6 @@ Input image | | goes to output image | | C-D C-A ~~~ * Numeric value: 7 (all bits set). - * - * \sa https://en.wikipedia.org/wiki/Examples_of_groups#dihedral_group_of_order_8 - * - * The set of 2D plane transforms is also known as the symmetry group of a - * square, described in the link. Note that the group can be generated by - * only 2 elements (the horizontal flip and a 90 degree rotation, for - * example), however, the encoding used here makes the presence of the vertical - * flip explicit. */ /**