From patchwork Fri Jul 2 15:09:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12799 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 36D15C0100 for ; Fri, 2 Jul 2021 15:09:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B324868511; Fri, 2 Jul 2021 17:09:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Y4SdoOsU"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 00F526850A for ; Fri, 2 Jul 2021 17:09:57 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id w13so6876737wmc.3 for ; Fri, 02 Jul 2021 08:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=; b=Y4SdoOsUmxqctbpdZQyGGbT1nbZQW4qgsUXMA55WDXQP5x3daS7CkC4dZvDccoMFkp /uO8e0++zeAs0pCWEe2vYojwSonQQw54CGuuPWjV7R+F+SNpxyvQuKRgAUZ/3YhtbGeT A8OwHdD8Y3TV65cL9mD73Y6/JJBdhqYU/HpVtXUAyQOvPVOMp9rWNWZJz/UP/QgsiXnQ WwuHjlmDABnO6ed7vA+jwaquGcLYlv2CkTHaDmgwxx+b75DYIFRFsnGQl/GItJtxz2AV RsDRPhPO2WFygaAp3/yW5eVUOUIB2vkeaAwHk5qtfn91cOGBg/VQlWbLpvOMpJizMN6c qUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=; b=PjoYB9pBrOkEnlkqrdKtvHaMGLghC3sBjv7e/LFMmyDHKPPGOGxnJso8vzp6Y/H8KZ nDzm4DLCtNtUQ+U4doKzrits31JMiWrWQKZvOtq3SgphdT61uf9j7Tud3vNzw3tzOe0i VeQykSevqUIg0E8Ksgyb6fPxPH1EmuwHlb+p6rV+TATTQ0wQQBDyclVvUWo+YStBvDyY JbblpCdT2VUft0TOPD5L+qPBglNLK22ls9pYCKVBbQjVG8pB8+kpha+bZbvjEsGQjZe3 NyjpDaVG7m8Z4QmkcKexJCLJ2Knbo7VyDrbWYEkxpcNlIq/oHQBxF9N7YlFLK1SpCojD YN7A== X-Gm-Message-State: AOAM531d2ohCZcDylbyllPSTSACIgII3uOav3vgFOSubmRbzIWFjYRgZ vO1MYQUsuqE9LR+sGsxZFZsnFoed06w1tw== X-Google-Smtp-Source: ABdhPJx8EcTIrVVmst9jVYK0irij2f0jF2ujpLXYoWBbbLW8bF0y4BtiICfs1xyWWg0Q4bUsWY2pMQ== X-Received: by 2002:a1c:7410:: with SMTP id p16mr5841wmc.24.1625238596534; Fri, 02 Jul 2021 08:09:56 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id n4sm3619335wrw.21.2021.07.02.08.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 08:09:56 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 2 Jul 2021 16:09:40 +0100 Message-Id: <20210702150940.226941-9-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210702150940.226941-1-naush@raspberrypi.com> References: <20210702150940.226941-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 8/8] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 8fb98a49da63..1dd7fd68c3e9 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);