From patchwork Fri Jul 2 15:09:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12792 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B685DC0100 for ; Fri, 2 Jul 2021 15:09:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9168468506; Fri, 2 Jul 2021 17:09:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="bn8u61qN"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 52FC1684EA for ; Fri, 2 Jul 2021 17:09:51 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id j2so12833902wrs.12 for ; Fri, 02 Jul 2021 08:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C0gP47j5UgDK8yhhXHaI9V3iumMujPU1ZTL7xRjpncw=; b=bn8u61qNrI4phw/d3UQJpZ0mvTCZTVirrN4iXvZV8juVuAKqeGKZvaSlGpqEQemEoj xcQC8DOj5eHw8a6Tj6fvk48YCtXJbnEMQE21qKK4WQcJJTOn43uLdRyU/P4TAaaCqSyB q/+pGevz/Sd7ZI96Al+i1y8/JaFUwsMAvn0S04+6U6X3U0gDOgA+7fc4sMsFXH7rZbfs BeCUDwVxehSSzAM46ElQlN4sHTXzYx1jNfmbLLs/P3lzcI/G6gWsNSh21owETitZQ9s/ x0U65cMUvs1x5eaN1YJjMo3W03NBhWYuEaJ1sD3PRY7SpF5yOLBK54QO7ccYMYk6bYKJ Vpdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C0gP47j5UgDK8yhhXHaI9V3iumMujPU1ZTL7xRjpncw=; b=dOVNOMcE/B5+EFkMFrU+2PHqon8XwGHXn+NlXT7uSlzLSD0NN53/25X3nTaUXvYibC dZMBLiRecn0S53VvXZu6FlBB3f2wSXy1eJSRm/0SvmLaupjBZ5K5PlGlwaA/LsAslz7M 5mp//zAzCuWUVSCn2N5m2PKG42MzAQJg+gD2DtcPuZWRsvP8c7hJ62Io29uDJk8MOTUx gdc3wZPKOrDUnLcu+ZBqbm8i5lgeutNFHZOmzU/fQJPmJQ3GTPjUK8L7Q/DgN2xnLRfq 7ZBkz7+whKNJ+Q7FtPd/b0wHwPOWmttMnW+4aj+I0683+sNmYmp5G2xOMIZbd2cxVsgl Ta/w== X-Gm-Message-State: AOAM533Q+pnbR8xU4so2p3q03S8axcwE4YFpcxyupiUfEjIxMr4IRFDo p92P0B3nBJ8g3wYSE7s7PBhpc556KtbfTw== X-Google-Smtp-Source: ABdhPJxMQWcAlGyOtqqD5pSE8LN3n/xrydOBodjXFlw3D9m5uyjJ+EdVY3HVIioMEQEvFtfx5Snx/w== X-Received: by 2002:adf:e384:: with SMTP id e4mr84967wrm.317.1625238590876; Fri, 02 Jul 2021 08:09:50 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id n4sm3619335wrw.21.2021.07.02.08.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 08:09:50 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 2 Jul 2021 16:09:33 +0100 Message-Id: <20210702150940.226941-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210702150940.226941-1-naush@raspberrypi.com> References: <20210702150940.226941-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This header file is no longer C compatible, so remove the extern "C" declaration. Replace C++ style comments with C style based on libcamera guidelines. There are no functional changes in this commit. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman --- .../raspberrypi/controller/device_status.h | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h index f74235248b12..733378dbfa27 100644 --- a/src/ipa/raspberrypi/controller/device_status.h +++ b/src/ipa/raspberrypi/controller/device_status.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: BSD-2-Clause */ /* - * Copyright (C) 2019, Raspberry Pi (Trading) Limited + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited * * device_status.h - device (image sensor) status */ @@ -8,25 +8,19 @@ #include -// Definition of "device metadata" which stores things like shutter time and -// analogue gain that downstream control algorithms will want to know. - -#ifdef __cplusplus -extern "C" { -#endif +/* + * Definition of "device metadata" which stores things like shutter time and + * analogue gain that downstream control algorithms will want to know. + */ struct DeviceStatus { - // time shutter is open + /* time shutter is open */ libcamera::utils::Duration shutter_speed; double analogue_gain; - // 1.0/distance-in-metres, or 0 if unknown + /* 1.0/distance-in-metres, or 0 if unknown */ double lens_position; - // 1/f so that brightness quadruples when this doubles, or 0 if unknown + /* 1/f so that brightness quadruples when this doubles, or 0 if unknown */ double aperture; - // proportional to brightness with 0 = no flash, 1 = maximum flash + /* proportional to brightness with 0 = no flash, 1 = maximum flash */ double flash_intensity; }; - -#ifdef __cplusplus -} -#endif