From patchwork Thu Jul 1 11:34:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12759 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0E695C3220 for ; Thu, 1 Jul 2021 11:34:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9B820684EA; Thu, 1 Jul 2021 13:34:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="g7C1M0yc"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 09C33684EA for ; Thu, 1 Jul 2021 13:34:50 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso4834249wmc.1 for ; Thu, 01 Jul 2021 04:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WkzBNnGjJ5EyXZGtKLLqJZkUqXd6Ab1czyjc/QkrYI0=; b=g7C1M0yc8Tus3qBFcLXCDcdHYo00sABrsSoSv+bcIF8I5YvreaOILn7zJNWYEjI0QW xliNPT0l9cWkRW/C/cpzKTov2W+3nuoriiZcCmtVjr52QTqaL/drqUPt9tmeCbSEQl+6 SOLvPcRyMp0Pprc2mYV4ueKkwPRlHd3sd/JCJIn4KsclRmjW7x5zou2TSAW8WD5w9YaR AUZVslkS6WIyfnJut7MweXTbDlNmW2ZrCIUW3L2ArqWgfLg/TxhRZi9xpBALM7QomjZG UtbjCxS3b6zUudv6wNmio0aEou3Ew1zmWa5ZBcIxUADMozei5M4mn5R6zheey8HW3akq ChZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WkzBNnGjJ5EyXZGtKLLqJZkUqXd6Ab1czyjc/QkrYI0=; b=VtZLwF0vs74MZZ/qPmMCkzacFwCTENPvNups6hII1zq6zMMscUnsIifeuikQrLaWr7 uW0bj3rDd4uBWXeK+Gx6t/Glxe6Vg9LRc+ftPTWTIGJZcdWJHdk2l7QtqZIPLekVQk+j aErjKRfLoZOcqtkzK2efrNitMxNV7VY5AB8YSnek8OXWXp3T4gSy2v9EuUphIHTHxml0 vLkhwgdIsE8Vs9lNwzoMjd9xcNJX2wjLHuU/yWGyqIsreavzFMS/jjQZVCJ+z8kBS6aG BrY6BGSLEIVaap8hO9uAiedcyTU83oJ0LACueHFQyyCQe+nM9m+8YhrRF1I39+dAnrDc REbA== X-Gm-Message-State: AOAM531ZR8AdfKk/uleaguaBc3XK2Agqzm+/+UZtDsUlpcP1R20jnThO sHjghMZ2Tvw7dxnuCTwJG864KP/bt5shpg== X-Google-Smtp-Source: ABdhPJyigk+yzgwWSpALqmnKV9r5tU8sMofUSytMHO82l+ighUPmcHol66gp83W4rfCS4EGOeDrd6g== X-Received: by 2002:a1c:771a:: with SMTP id t26mr10361322wmi.36.1625139289565; Thu, 01 Jul 2021 04:34:49 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id f6sm8076495wrs.13.2021.07.01.04.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 04:34:49 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Thu, 1 Jul 2021 12:34:42 +0100 Message-Id: <20210701113442.111718-5-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701113442.111718-1-naush@raspberrypi.com> References: <20210701113442.111718-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index dd20c854c788..e9bd724f5eac 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);