From patchwork Mon Jun 28 12:23:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 12725 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 870EBC3220 for ; Mon, 28 Jun 2021 12:23:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 10087684D6; Mon, 28 Jun 2021 14:23:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="aojMhd0i"; dkim-atps=neutral Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 99876684D3 for ; Mon, 28 Jun 2021 14:23:27 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id o33-20020a05600c5121b02901e360c98c08so11862524wms.5 for ; Mon, 28 Jun 2021 05:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E9nCDyDkwew2QWgv+wjfgUYgt/K9qJddnw+iPJh6jz8=; b=aojMhd0i21Fi7CHeq+qaceC+y5N6HPBE+6vHsPs9gWeBbNvok+nYSorO+HVFd0KAol S8OwglgcPBLKxoS/U2eUzhMBocguZsQbUNcOv2Kfi/K903OHTXcBPL2kmEc2xnMtVsNn 7gaZdO9WSp7qSti1TkjsT6vRU7xwKexkRKulpkCr/7udCUJGirOB4f87r5IDPj6ho1q2 YfH2ptjqlRnzfzh+SCWXKgEPablyVn03l4Un+udqV5vbhumNX1NKeOOxiWwRE7XHbSm5 rgUk4JOn779xX8+G7jSmhv2vk1tNW556rC+bKY5yUA1p7Gbo5fxPJ1hDE46W5VqLbtJv mZgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E9nCDyDkwew2QWgv+wjfgUYgt/K9qJddnw+iPJh6jz8=; b=WXD6ZnWjK0BReSj9/+5BTaYXwtkfuHISn85Z+I0yJL2cfHC2C+okndkjjsVm5Ry49w tS0uiixgUOeKxsWifxAAU2sj49j+ZXxDdz9JEhBv2z1hDZRpPIIOS4tAhw1VOAKRxIb3 c/krXvDmU1rLZXrzA4MXeTHUUmZfq1Mr9DHv4hkl6aYTkHg5z4cdx53a1NPKqD04j4ms 2Im1t4f5mrmoMHh4CUxFt+tT8qd+aV0DQMQHYxTaBLjDTZgQFlYs+NDTwNkYy9s6CD0B Oma4YmLvFZBeJLKhTZwefuK6aBlJ0rnSSOw4JVGeG+z+U+v7IJyBZduq4AtkJyo5Pdf/ BIoA== X-Gm-Message-State: AOAM531+yylGYl2NjomHdRXiKKwBs99GV8n6ceBFusGmglttGDj/MukY JMo7lOILD4yMLEGXLtii+BJOf3D+ekXhZg== X-Google-Smtp-Source: ABdhPJx443yqzdVg7CdNhwVIHRNPJu0ahteDp3Ba60sNd/LQujPrAQhrsNfOI9MlOKR26oYP3USXmA== X-Received: by 2002:a05:600c:3502:: with SMTP id h2mr23683974wmq.68.1624883007121; Mon, 28 Jun 2021 05:23:27 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:1ce1:9965:4328:89c4]) by smtp.gmail.com with ESMTPSA id s62sm19606542wms.13.2021.06.28.05.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:23:26 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 28 Jun 2021 13:23:23 +0100 Message-Id: <20210628122324.14541-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210628122324.14541-1-david.plowman@raspberrypi.com> References: <20210628122324.14541-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Warnings about the lack of AWB status results are demoted to being just "Debug". With monochrome sensors becoming more common this would otherwise overwhelm the console output, and in practice nothing is really lost as it is normally very evident if AWB is failing to run. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp index 55e80ac7..2c95f287 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata) awb_.gain_g = 1.0; awb_.gain_b = 1.0; if (image_metadata->Get("awb.status", awb_) != 0) - LOG(RPiAgc, Warning) << "Agc: no AWB status found"; + LOG(RPiAgc, Debug) << "Agc: no AWB status found"; } static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb, diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp index b0d24aa2..ef99c1b0 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp @@ -267,8 +267,8 @@ double get_ct(Metadata *metadata, double default_ct) AwbStatus awb_status; awb_status.temperature_K = default_ct; // in case nothing found if (metadata->Get("awb.status", awb_status) != 0) - LOG(RPiAlsc, Warning) << "no AWB results found, using " - << awb_status.temperature_K; + LOG(RPiAlsc, Debug) << "no AWB results found, using " + << awb_status.temperature_K; else LOG(RPiAlsc, Debug) << "AWB results found, using " << awb_status.temperature_K;