From patchwork Fri Jun 18 16:18:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 12651 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9EBABC3219 for ; Fri, 18 Jun 2021 16:18:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E457A6894C; Fri, 18 Jun 2021 18:18:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Sxx32nof"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 66ACE68941 for ; Fri, 18 Jun 2021 18:18:14 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id j2so807882wrs.12 for ; Fri, 18 Jun 2021 09:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=; b=Sxx32nofExNzHAO/sOzvl3bvOqeoNalp3aMai1nJpn36snprfVDz677miptn6xarRL wH9yciEPzRXR8/+aQFVe4deV9gPlj9wS7kod8sYQ0G9ppeW5mpf+x/Pr9WjRcI3i1GA5 Cy+BJ8VxXdLsLlM/icxmg7eKmccHGVrpETn/OcQ+M4igKu9rVj6izRMJVLIDH66Txasc daItJ31x28vKeOlbRHjiFEdT8Xb0IXqGmwW2LlF74CO2bTs3i10T5zGMOEIN5V2PMJZR N1JWct4Kk9cktWZFvg8at+qURYybPFPkDE7Fl0b226wR540Z7C87gCBcOhSjjYc/3YRI OhZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=; b=cTkSdNlC7ETC1OKeXeeqM1hZUDr+K5NNWEFRMVFj9cjHxiJXt8tDO5C9m1CtNLicdS p86pr2j8Xq/GtBZ4K0eBteZ7055zOwsEqo+JlXTDK1s+U6lYL8jhtv1X7ft9sfhsgRgl xhSipktgCjX40npTyL2CstHqfn+78X9fLzT24o2xMjKMhoxK086TFxWDQYDV/1WPuF1N lnf6JetiwVSqg30v75Vb6sz0utJYb+X09C3nc6oMl+aB2KPsbg5W1EHwcsqQFJQmsrzw itJMAxQIgBE7VSX81SmQ9+IqPOjpcY9amknAsj0bvtD4ZMaWaPvkqK5Jvmo2lakFII0R ptwg== X-Gm-Message-State: AOAM531Smx8KkJYk/Z8iaQQdZznhnd74PcuZLN/kICDK6W54/I4iCl92 JLff7dTu8KB8V8jfuz1Q55yuWNZt8NifNH0N X-Google-Smtp-Source: ABdhPJxiB4y9zbs1b0eHKp7BrOBFj8WaSRdX16WMZnTj8INISPAoQHwQxHcldFbeJCeEq/ENQvpdEw== X-Received: by 2002:a05:6000:1084:: with SMTP id y4mr12159565wrw.173.1624033093979; Fri, 18 Jun 2021 09:18:13 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id z5sm8908492wrp.92.2021.06.18.09.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 09:18:13 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Jun 2021 17:18:06 +0100 Message-Id: <20210618161807.24242-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210618161807.24242-1-david.plowman@raspberrypi.com> References: <20210618161807.24242-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Warnings about the lack of AWB status results are demoted to being just "Debug". With monochrome sensors becoming more common this would otherwise overwhelm the console output, and in practice nothing is really lost as it is normally very evident if AWB is failing to run. Signed-off-by: David Plowman Reviewed-by: Kieran Bingham --- src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp index 55e80ac7..2c95f287 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata) awb_.gain_g = 1.0; awb_.gain_b = 1.0; if (image_metadata->Get("awb.status", awb_) != 0) - LOG(RPiAgc, Warning) << "Agc: no AWB status found"; + LOG(RPiAgc, Debug) << "Agc: no AWB status found"; } static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb, diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp index b0d24aa2..c58ef7d0 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp @@ -267,7 +267,7 @@ double get_ct(Metadata *metadata, double default_ct) AwbStatus awb_status; awb_status.temperature_K = default_ct; // in case nothing found if (metadata->Get("awb.status", awb_status) != 0) - LOG(RPiAlsc, Warning) << "no AWB results found, using " + LOG(RPiAlsc, Debug) << "no AWB results found, using " << awb_status.temperature_K; else LOG(RPiAlsc, Debug) << "AWB results found, using "