From patchwork Tue Jun 15 10:51:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 12598 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CFDD0BD78E for ; Tue, 15 Jun 2021 10:51:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 915DD68948; Tue, 15 Jun 2021 12:51:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="jSG9JzmL"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CDEFF68949 for ; Tue, 15 Jun 2021 12:51:43 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id h11-20020a05600c350bb02901b59c28e8b4so1456370wmq.1 for ; Tue, 15 Jun 2021 03:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=; b=jSG9JzmL7FH1Ntj7dKStsCVZYENy1MFtP3z1IqyYGNFYNJPhdRAwBAO2V6kJqvd4Mb mJAUPJ75mpuXT78PGfs6U9HYx+WFg5Rbob6EXmDULigaUwJPCu6LbIZCMgA6hLmL6oAA m2/dEuiLuaO1vrjIThbINBrnfb1UR3e5pDYM/95+j1KIztbzh1NuDnD6wCGLZi4CRY6l fCAZMjhRukR5E72ROTCPzoSfF5/lpsROlVEbSO3cVbGe4toK3NneM7yHbzyQrrEfaXjG 3hvWHcUFTIH52sq8QHtA3hI4je8IgEkQPy+3vHHbT6e7IN9doFqniGwLluSJlq4yIZKu 4BIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=; b=mGyhr2i0mab9DiGz40b/906OhZKUiUF7/8GXwcSL4IY29JfNd9OJr5l2dJraq2EWNF RsfNQLKN7iGH3+TL6UkZDjS2b/L8alWCDoc7ZfGw/nyHCT6tCMhf1nvAdORYN8QDqcCl TbgtWt+8B887/iuBTHrnfq7iWd4Aio0Wp1ohXzJ3zOhrTyZdkhb1LmCIHSDsYPm74PTA iaTZPKRopFqTbxgZ0veC54rC/im0ouDJp3IuOPZXTtuqKs1uSw9hRetaY4nTi5WNZryV VApQMAbJ8eNoeOQDqw5vxv9hXgjf0g5RfhYwPPEnrVOZ/POhnjiN0ScD01oFZ+85DWMT 5img== X-Gm-Message-State: AOAM530nQWVrJVpdAH6P0b2KpDtcsKcrwZ8dgD405tfTB55NBOAB/w4d 4GHWICWZ66kN6JPLG+SoC5O75APN0paD8eua X-Google-Smtp-Source: ABdhPJyvwVCV5Sbtgc8uc0CKRofwOsC6O2KnQQ2jMwVcp/bUxmso9B1VZ0sdZUN873twgpjF9tLxpA== X-Received: by 2002:a05:600c:4f47:: with SMTP id m7mr4300541wmq.8.1623754303415; Tue, 15 Jun 2021 03:51:43 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:1ce1:9965:4328:89c4]) by smtp.gmail.com with ESMTPSA id u15sm1796300wmq.48.2021.06.15.03.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 03:51:42 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 15 Jun 2021 11:51:38 +0100 Message-Id: <20210615105139.16171-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210615105139.16171-1-david.plowman@raspberrypi.com> References: <20210615105139.16171-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Warnings about the lack of AWB status results are demoted to being just "Debug". With monochrome sensors becoming more common this would otherwise overwhelm the console output, and in practice nothing is really lost as it is normally very evident if AWB is failing to run. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck --- src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp index 55e80ac7..2c95f287 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata) awb_.gain_g = 1.0; awb_.gain_b = 1.0; if (image_metadata->Get("awb.status", awb_) != 0) - LOG(RPiAgc, Warning) << "Agc: no AWB status found"; + LOG(RPiAgc, Debug) << "Agc: no AWB status found"; } static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb, diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp index b0d24aa2..c58ef7d0 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp @@ -267,7 +267,7 @@ double get_ct(Metadata *metadata, double default_ct) AwbStatus awb_status; awb_status.temperature_K = default_ct; // in case nothing found if (metadata->Get("awb.status", awb_status) != 0) - LOG(RPiAlsc, Warning) << "no AWB results found, using " + LOG(RPiAlsc, Debug) << "no AWB results found, using " << awb_status.temperature_K; else LOG(RPiAlsc, Debug) << "AWB results found, using "