From patchwork Mon Jun 14 10:00:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 12590 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6F4C9BD78E for ; Mon, 14 Jun 2021 10:00:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2F62868932; Mon, 14 Jun 2021 12:00:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="MMnrpBIQ"; dkim-atps=neutral Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5041768939 for ; Mon, 14 Jun 2021 12:00:49 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id g204so11760254wmf.5 for ; Mon, 14 Jun 2021 03:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BbEDq3QFhNs6q2Yo/EM3SLXoECkNfP5qpJtL0OjICrc=; b=MMnrpBIQ/k5aPK2T3eRenoR7To5f4+CykiuE3yFY/hBmusAF04+it1bPtSGReoD/aP iXVSUTuz88Fnp41iwo/TXakD9Pl3FezecaM2BMXdgC94S68iCLyEkxrUquxmTh/p1Yor UGSLmwrjZp30L5fhFbJitCNSFsUkkITyS3jUpIp1433CJd75kJmWFPS61nfGQ4bk0XD2 3qXKE/jcdVUxs1cUhrWncmN6gtGXKH5CLP1pJ0B4W/uKgYCYV0V+XFzOPhld5CrQL2Vw Dh2qhTMA+/Vn8zGpawNOmN68aa9iO0sgNGF6UmgMuRuTtNFd3pmhusZOjFvcNRJfK0nr 9XHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BbEDq3QFhNs6q2Yo/EM3SLXoECkNfP5qpJtL0OjICrc=; b=VU4WVQZk4i5l84XCXpsGh37vwD+7eU4fOwrkrniwFVStnEEZ5DbLDLsQy2jhbjzqfB sLgXqIWa06pUsTYw12VO+mqlUZOwh0GWg4atsonGxEPcrAH+/8ZQ9MT1EJkYDqrSjr6c iglZXTXf4sUDHrCfw51T2jHAGe9//ypj7Yy5f49/dF2FN+YRHsqzGmiQKjc1eJWoyZVP S3g41pFDN1CRr0od6WIO6zlSr1NONVH5HSAPLytAzu46f1n19ElRAkLFRdFIQTC2pj2i f93juI9JU7r5MqVpmsVOYGFvHDCNKVQQzXUiawUFt9Gl504lGK+mIQAed7ki3jB14QVi SWdw== X-Gm-Message-State: AOAM5307hvFCM8LccMXdy/NVcpqYLPfW34YxT79UMii+NRJCGAlIB42c oDwbZqLLIdvu1i6nQd8zYwjukbtAoLql+w== X-Google-Smtp-Source: ABdhPJxR3oB/19Ug8cHU4DbV/ejq37MI/B7OmYQOGVAEftWS4nBrCAjaV/ojmz9CLaEseOqxdzi10w== X-Received: by 2002:a05:600c:3594:: with SMTP id p20mr29412156wmq.52.1623664848795; Mon, 14 Jun 2021 03:00:48 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:fd93:d554:2dff:83ca]) by smtp.gmail.com with ESMTPSA id 89sm16235959wrq.14.2021.06.14.03.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 03:00:48 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 14 Jun 2021 11:00:40 +0100 Message-Id: <20210614100040.3054433-5-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210614100040.3054433-1-naush@raspberrypi.com> References: <20210614100040.3054433-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: Make variable names consistent X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" s/DefaultAnalogueGain/defaultAnalogueGain/ s/DefaultExposureTime/defaultExposureTime/ Change these for consistency with the other static const variables. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman --- src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 8a8e9c0a52ab..e15d49e49645 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -58,8 +58,8 @@ using namespace std::literals::chrono_literals; using utils::Duration; /* Configure the sensor with these values initially. */ -constexpr double DefaultAnalogueGain = 1.0; -constexpr Duration DefaultExposureTime = 20.0ms; +constexpr double defaultAnalogueGain = 1.0; +constexpr Duration defaultExposureTime = 20.0ms; constexpr Duration defaultMinFrameDuration = 1.0s / 30.0; constexpr Duration defaultMaxFrameDuration = 250.0s; @@ -389,8 +389,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, /* Supply initial values for gain and exposure. */ ControlList ctrls(sensorCtrls_); AgcStatus agcStatus; - agcStatus.shutter_time = DefaultExposureTime; - agcStatus.analogue_gain = DefaultAnalogueGain; + agcStatus.shutter_time = defaultExposureTime; + agcStatus.analogue_gain = defaultAnalogueGain; applyAGC(&agcStatus, ctrls); ASSERT(controls);