From patchwork Tue Jun 8 21:27:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12531 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4E695BD22E for ; Tue, 8 Jun 2021 21:27:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C1D33602C5; Tue, 8 Jun 2021 23:27:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nB2DIvEQ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 723D4602A7 for ; Tue, 8 Jun 2021 23:27:37 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DECAFDD; Tue, 8 Jun 2021 23:27:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623187657; bh=qWZ+6tCb3ghgS2ylXbti1vcvcAbZeLJONoCF5a5BKPo=; h=From:To:Cc:Subject:Date:From; b=nB2DIvEQ7BqBLYXYjghl3krNQ4etc6aDxra0oa2Kcilj/d4eSrlt2D0Km2zFk26QD TlqODhuHqbVCZ8pT8t55GYkqyIL44/rznia6zY1PkHNMtn3TMpISRWCiIyz/5rCY2Y Vd9K58Q+9Ced0HFHsr2bmMgkwnY7sLNuRNOxSatU= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Wed, 9 Jun 2021 00:27:14 +0300 Message-Id: <20210608212714.9381-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: ipu3: Fix struct/class mismatch in forward declaration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ipu3_agc.h forward-declares the IPACameraSensorInfo structure, but incorrectly declares it as a class. This causes a compilation error with clang: include/libcamera/ipa/core_ipa_interface.h:24:1: error: 'IPACameraSensorInfo' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags] struct IPACameraSensorInfo ^ ../../src/ipa/ipu3/ipu3_agc.h:21:1: note: did you mean struct here? class IPACameraSensorInfo; ^~~~~ struct Fix it. Fixes: 384a53d3cdf7 ("ipa: ipu3: Calculate line duration from IPACameraSensorInfo") Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Hirokazu Honda Reviewed-by: Umang Jain Tested-by: Umang Jain --- src/ipa/ipu3/ipu3_agc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h index 99a582a9fdcf..f3d4055761e6 100644 --- a/src/ipa/ipu3/ipu3_agc.h +++ b/src/ipa/ipu3/ipu3_agc.h @@ -18,7 +18,7 @@ namespace libcamera { -class IPACameraSensorInfo; +struct IPACameraSensorInfo; namespace ipa::ipu3 {