From patchwork Tue Jun 1 11:24:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12479 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 483A8C3205 for ; Tue, 1 Jun 2021 11:25:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0D37968921; Tue, 1 Jun 2021 13:25:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Es6HgiTv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C321D68921 for ; Tue, 1 Jun 2021 13:25:09 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.189]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A58FA2A; Tue, 1 Jun 2021 13:25:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622546709; bh=wW8NiHLVupDFA9ThJHZkFhCSlsE3LtiZ66+txiIF2XM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Es6HgiTv81OdsRHRBGhNL1590RfWFhEYoM4sxBije7q7D4GsNtxMNxF+DbGtrXdGF h2NWmmQet09P4RIKYRD/jEvgk/hqBkSWt4KMqtFynUQSqjqsd+giH94b5LF92r4OpX evV+Lac26mY2uzxXOXy9o4NFn5MX/P1FyaqTXlXI= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Tue, 1 Jun 2021 16:54:55 +0530 Message-Id: <20210601112456.118755-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210601112456.118755-1-umang.jain@ideasonboard.com> References: <20210601112456.118755-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] android: Make FRAME_DURATION key available in static metadata X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Report ANDROID_SENSOR_FRAME_DURATION as an available key for CTS to read out the value of frame duration we set in CameraDevice::getResultMetadata(). Failing to do so might fail the CTS test: - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl Fixes: 3beb1accac1d ("android: camera_device: Fix sensor frame duration") Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Hirokazu Honda --- src/android/camera_device.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index fddc07ff..fe332ec3 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1422,6 +1422,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata() ANDROID_REQUEST_PIPELINE_DEPTH, ANDROID_SCALER_CROP_REGION, ANDROID_SENSOR_EXPOSURE_TIME, + ANDROID_SENSOR_FRAME_DURATION, ANDROID_SENSOR_ROLLING_SHUTTER_SKEW, ANDROID_SENSOR_TEST_PATTERN_MODE, ANDROID_SENSOR_TIMESTAMP,