From patchwork Thu May 27 01:01:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12432 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D6831BDB80 for ; Thu, 27 May 2021 01:02:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 17F5268924; Thu, 27 May 2021 03:02:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fXkXDMjW"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D006050E for ; Thu, 27 May 2021 03:02:01 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 56288124E for ; Thu, 27 May 2021 03:02:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622077321; bh=KcSF8v+kDv4XUSu7x7HEcq+kRgaI7jHNCZ+gc6z3Cn0=; h=From:To:Subject:Date:From; b=fXkXDMjWS/3xJQEsqOxiVj9BQQVbNs/uFRCl/OFRUWqO+ODXBfb93AqoR7HM2b7uV Zn8TGmUdYorn2drQIwf8aK8Gn/88mUpNJjQiVy0AGDjGTurzEITujVfCtdTKzKCozb 4IeJ+rT9/K32cKQokG6x1GnebHC2G9opxITl+Eio= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Thu, 27 May 2021 04:01:48 +0300 Message-Id: <20210527010149.30601-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect inclusion of unistd.h X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The standard C library close() and lseek() functions require inclusion of the unistd.h header. Include it explicitly where needed instead of relying on indirect inclusion. Signed-off-by: Laurent Pinchart Reviewed-by: Hirokazu Honda Tested-by: Paul Elder --- src/android/camera_device.cpp | 1 + src/android/camera_worker.cpp | 1 + src/android/mm/generic_camera_buffer.cpp | 2 ++ 3 files changed, 4 insertions(+) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 7fc4ddb024c1..81509f57d1b7 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp index 9f727826e23f..98dddd9eb13b 100644 --- a/src/android/camera_worker.cpp +++ b/src/android/camera_worker.cpp @@ -10,6 +10,7 @@ #include #include #include +#include #include "camera_device.h" diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp index 334498c1867f..cca88cf3632f 100644 --- a/src/android/mm/generic_camera_buffer.cpp +++ b/src/android/mm/generic_camera_buffer.cpp @@ -7,6 +7,8 @@ #include "../camera_buffer.h" +#include + #include "libcamera/internal/buffer.h" #include "libcamera/internal/log.h"