From patchwork Wed May 26 07:15:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12422 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A5763C3200 for ; Wed, 26 May 2021 07:15:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0B39D68922; Wed, 26 May 2021 09:15:53 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="oTa88SVR"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DF5F6891E for ; Wed, 26 May 2021 09:15:51 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.203]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 440E7332; Wed, 26 May 2021 09:15:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622013351; bh=PoQ2SsGOaNrjtfdGvJyyxwH7+bAMCf6y8+BL8kxDPa4=; h=From:To:Cc:Subject:Date:From; b=oTa88SVR5+N/FKW8UUkTimXVyQH0q9dFodvUYeZSl7RwiVCmS5HWO3jaDSrVFLtvm TkWUijKBIeW+DLKLLNK9kIknzb25T41Gmiy4FsOcYQYy5Zmv2toe/2rAKcHHCugTGc 4wwNv6DZ7Boc3Ze28+N5YvenSwUKPWsyme/CBF0I= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Wed, 26 May 2021 12:45:42 +0530 Message-Id: <20210526071542.586096-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL configuration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" nautilus has two internal cameras, one UVC and one for the IPU3. However, libcamera assumes all UVC cameras as 'external' hence, mark the location of UVC camera in HAL configuration as 'external' too. Note that the presence of UVC camera in camera HAL will complain: > ERROR HAL camera_device.cpp:701 '\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647': Failed to map mandatory Android format IMPLEMENTATION_DEFINED (0x00000022): aborting > ERROR HAL camera_hal_manager.cpp:153 Failed to initialize camera: \_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647 This is related to a known issue of UVC cameras on HAL which do not provide NV12 by default. Also, if we don't mention the UVC camera in the config: > ERROR HALConfig camera_hal_config.cpp:393 Camera '\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647' not described in the HAL configuration file > ERROR HAL camera_device.cpp:701 '\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647': Failed to map mandatory Android format IMPLEMENTATION_DEFINED (0x00000022): aborting > ERROR HAL camera_hal_manager.cpp:153 Failed to initialize camera: \_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647 Signed-off-by: Umang Jain --- src/android/data/nautilus/camera_hal.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 src/android/data/nautilus/camera_hal.yaml diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml new file mode 100644 index 00000000..f2d31e1c --- /dev/null +++ b/src/android/data/nautilus/camera_hal.yaml @@ -0,0 +1,8 @@ +cameras: + "\\_SB_.PCI0.I2C2.CAM0": + location: back + rotation: 0 + + "\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647": + location: external + rotation: 0