From patchwork Thu Apr 22 15:46:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 12081 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B3A31BDB15 for ; Thu, 22 Apr 2021 15:46:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0BC3D68806; Thu, 22 Apr 2021 17:46:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H1if2J0Y"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E750F60514 for ; Thu, 22 Apr 2021 17:46:28 +0200 (CEST) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:e96c:3f42:9018:e1b2]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 550453EE; Thu, 22 Apr 2021 17:46:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619106388; bh=cQULgEDAWBKQhhNTJekfS2RwYU45E2r5td0G5RDcCLM=; h=From:To:Cc:Subject:Date:From; b=H1if2J0YWy8YdnTGDq/mzyQaI6u2EXylZP8wz830xnt7qlRf3NhHpp9g18xETlXoY JdxBIrWjzJ65IpR2OHMqBtYAXXV8i/mDmglJtzreqrR4YpHGQ8eNWwFpNPV2Pfvyum CXoPctZIxMJoBF0jDwevCrdC4xjVs52qtOYRqqL4= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Thu, 22 Apr 2021 17:46:26 +0200 Message-Id: <20210422154626.119605-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] ipa: ipu3: fix coverity issues in AWB X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The BNR configuration structure has inconsistent initialisation of two members. This was picked up by Coverity, after merge. While this code is still functional, fix them to be consistent with the other initialisations within the struct. Reported-by: Coverity CID=320056 Reported-by: Coverity CID=320058 Signed-off-by: Jean-Michel Hautbois Reviewed-by: Kieran Bingham Tested-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- src/ipa/ipu3/ipu3_awb.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp index 060d1e18..f8788065 100644 --- a/src/ipa/ipu3/ipu3_awb.cpp +++ b/src/ipa/ipu3/ipu3_awb.cpp @@ -96,14 +96,14 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = { .wb_gains_thr = { 255, 255, 255, 255 }, .thr_coeffs = { 1700, 0, 31, 31, 0, 16 }, .thr_ctrl_shd = { 26, 26, 26, 26 }, - .opt_center{ -648, 0, -366, 0 }, + .opt_center = { -648, 0, -366, 0 }, .lut = { { 17, 23, 28, 32, 36, 39, 42, 45, 48, 51, 53, 55, 58, 60, 62, 64, 66, 68, 70, 72, 73, 75, 77, 78, 80, 82, 83, 85, 86, 88, 89, 90 } }, .bp_ctrl = { 20, 0, 1, 40, 0, 6, 0, 6, 0 }, - .dn_detect_ctrl{ 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 }, + .dn_detect_ctrl = { 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 }, .column_size = 1296, .opt_center_sqr = { 419904, 133956 }, };