From patchwork Tue Apr 20 13:07:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 12013 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EE401BDB16 for ; Tue, 20 Apr 2021 13:07:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 368D068856; Tue, 20 Apr 2021 15:07:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EZVAI5UA"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0135E68840 for ; Tue, 20 Apr 2021 15:07:47 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C8238AD; Tue, 20 Apr 2021 15:07:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618924066; bh=bh91nfL9I021cEfFTqVmCZcvRLjgxiXMG8vnDBDBZQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EZVAI5UAPWXxlaFik7TIJNNBaMjWZyUTyScUTksme2DoZCxl/VBpFBznNKXnwn+Yy 4ONyCufYz6DX7vIvRFPU3ljRV0Nqf9UQrpb27mtJUw8P1oXigNloZMNM2vt4VfKoll FVTDqKKw4gaAj8RQT4zET8E7MF7S1ZM30wqkhXF0= From: Kieran Bingham To: libcamera devel Date: Tue, 20 Apr 2021 14:07:38 +0100 Message-Id: <20210420130741.236848-4-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210420130741.236848-1-kieran.bingham@ideasonboard.com> References: <20210420130741.236848-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1: Fail RkISP1FrameInfo can't be found X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The RkISP1FrameInfo structure associated data sent to the IPA and is essential for handling events. If it can not be found, this is a fatal error which must be fixed. Signed-off-by: Kieran Bingham Reviewed-by: Jean-Michel Hautbois Reviewed-by: Laurent Pinchart Reviewed-by: Hirokazu Honda --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 549f4a4e61a8..c75666391222 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame) if (itInfo != frameInfo_.end()) return itInfo->second; - LOG(RkISP1, Error) << "Can't locate info from frame"; + LOG(RkISP1, Fatal) << "Can't locate info from frame"; + return nullptr; } @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer) return info; } - LOG(RkISP1, Error) << "Can't locate info from buffer"; + LOG(RkISP1, Fatal) << "Can't locate info from buffer"; + return nullptr; } @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request) return info; } - LOG(RkISP1, Error) << "Can't locate info from request"; + LOG(RkISP1, Fatal) << "Can't locate info from request"; + return nullptr; }