From patchwork Tue Apr 20 09:38:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12009 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4B12DBD816 for ; Tue, 20 Apr 2021 09:38:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B10CE68848; Tue, 20 Apr 2021 11:38:24 +0200 (CEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 93A1C68835 for ; Tue, 20 Apr 2021 11:38:23 +0200 (CEST) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 38B471BF218; Tue, 20 Apr 2021 09:38:23 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Apr 2021 11:38:59 +0200 Message-Id: <20210420093859.14280-3-jacopo@jmondi.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210420093859.14280-1-jacopo@jmondi.org> References: <20210420093859.14280-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/2] libcamera: class: Drop 'klass' argument from documentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The LIBCAMERA_D_PTR() and LIBCAMERA_O_PTR() macros do not require an argument, but the version of the macro consumed by Doxygen does. Fix this by removing the klass parameter from both macros in their documentation version. Signed-off-by: Jacopo Mondi Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- include/libcamera/class.h | 4 ++-- src/libcamera/class.cpp | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/libcamera/class.h b/include/libcamera/class.h index 466114ecfaf4..f384a4889588 100644 --- a/include/libcamera/class.h +++ b/include/libcamera/class.h @@ -48,8 +48,8 @@ public: \ #else #define LIBCAMERA_DECLARE_PRIVATE() #define LIBCAMERA_DECLARE_PUBLIC(klass) -#define LIBCAMERA_D_PTR(klass) -#define LIBCAMERA_O_PTR(klass) +#define LIBCAMERA_D_PTR() +#define LIBCAMERA_O_PTR() #endif class Extensible diff --git a/src/libcamera/class.cpp b/src/libcamera/class.cpp index 171f7c0a927b..28c35633d7db 100644 --- a/src/libcamera/class.cpp +++ b/src/libcamera/class.cpp @@ -95,9 +95,8 @@ namespace libcamera { */ /** - * \def LIBCAMERA_D_PTR(klass) + * \def LIBCAMERA_D_PTR() * \brief Retrieve the private data pointer - * \param[in] klass The public class name * * This macro can be used in any member function of a class that inherits, * directly or indirectly, from the Extensible class, to create a local @@ -105,9 +104,8 @@ namespace libcamera { */ /** - * \def LIBCAMERA_O_PTR(klass) + * \def LIBCAMERA_O_PTR() * \brief Retrieve the public instance corresponding to the private data - * \param[in] klass The public class name * * This macro is the counterpart of LIBCAMERA_D_PTR() for private data classes. * It can be used in any member function of the private data class to create a