From patchwork Tue Apr 13 12:25:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 11909 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 35A17BD224 for ; Tue, 13 Apr 2021 12:25:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E5E1E68800; Tue, 13 Apr 2021 14:25:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dwoioEfL"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 97D0E687EC for ; Tue, 13 Apr 2021 14:25:40 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C50F18AF; Tue, 13 Apr 2021 14:25:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618316739; bh=L42dyyRK+Oit+tEx0yz6PHx9kue8aWuC+IXDn8z+Gck=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dwoioEfLA2eKNnRlD9GU2riBUoz7Fm3DcUdVTeoZ9jQqdRc5UPI6eUSaxqaDkm7f9 ezRNljtRK7gf1LeW0nxTVfaCkTvpyxdAtRhQF4mGJ3ROte1D/mZaqfO2ZKQiVMGvKg UUWqZT4qJNn/dApWjaE64ok5diL+6QceAOt1T/r4= From: Kieran Bingham To: libcamera devel Date: Tue, 13 Apr 2021 13:25:32 +0100 Message-Id: <20210413122534.342138-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210413122534.342138-1-kieran.bingham@ideasonboard.com> References: <20210413122534.342138-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] libcamera: ipa_proxy: Scope ProxyState to IPAProxy X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ProxyState is only used by the IPAProxy, so it should remain inside that scope. This helps clarify the usage, and improves the documentation by bringing the (future) ProxyState documentation into the class. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- include/libcamera/internal/ipa_proxy.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h index 9fe446c35f04..ea9f0760c2fc 100644 --- a/include/libcamera/internal/ipa_proxy.h +++ b/include/libcamera/internal/ipa_proxy.h @@ -17,15 +17,15 @@ namespace libcamera { class IPAModule; -enum ProxyState { - ProxyStopped, - ProxyStopping, - ProxyRunning, -}; - class IPAProxy : public IPAInterface { public: + enum ProxyState { + ProxyStopped, + ProxyStopping, + ProxyRunning, + }; + IPAProxy(IPAModule *ipam); ~IPAProxy();