From patchwork Wed Apr 7 14:53:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11859 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4543BBD224 for ; Wed, 7 Apr 2021 14:54:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B7CFC687A2; Wed, 7 Apr 2021 16:53:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QV7asBZG"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BA88687A1 for ; Wed, 7 Apr 2021 16:53:58 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B009788F for ; Wed, 7 Apr 2021 16:53:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617807237; bh=W0BRucsyJGf88JUTp5QRVJ/N71jcgsQ0uUaLWigE/YU=; h=From:To:Subject:Date:From; b=QV7asBZGW19FjydXpc916IOvEIsGGeJ+71A1dCnG1NVdX+s5K4/75rYf212psTE0h elP9gtjs3iuRbf8qNqy+CuwOF9sW7q0grFRkliksMhxbJ9PKfzH9fI27qRbmRbX5Gu HV25iX3wKWhuboA8ewWm/uE9y3bt/pX18DA1awtk= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Wed, 7 Apr 2021 17:53:09 +0300 Message-Id: <20210407145309.16877-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: bound_method: Fix type of pack for void methods X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The BoundMethodPack used by the void BoundMethodArgs variant incorrectly specified the template argument as void * instead of void. This causes no functional problem, but results in space for an unused void * return value being reserved. Fix it. Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Fricke Reviewed-by: Kieran Bingham --- include/libcamera/bound_method.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h index 95a956530877..f216e3b56826 100644 --- a/include/libcamera/bound_method.h +++ b/include/libcamera/bound_method.h @@ -174,7 +174,7 @@ template class BoundMethodMember : public BoundMethodArgs { public: - using PackType = typename BoundMethodArgs::PackType; + using PackType = typename BoundMethodArgs::PackType; BoundMethodMember(T *obj, Object *object, void (T::*func)(Args...), ConnectionType type = ConnectionTypeAuto)