From patchwork Thu Apr 1 10:13:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11812 X-Patchwork-Delegate: paul.elder@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6AEE9C0DA4 for ; Thu, 1 Apr 2021 10:14:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 227F968785; Thu, 1 Apr 2021 12:14:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bT8TDX7z"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 23D0A68782 for ; Thu, 1 Apr 2021 12:14:05 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 80A40F7; Thu, 1 Apr 2021 12:14:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617272044; bh=7wpvxqxtt4w4YWjsL962OFpz2UjP/OB5emo3gR+5zCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bT8TDX7zPVkzl7vYFKtloh1jHLOttcAeqcAkOTnhfcZ9WlLFaIXhA3bQpESKOcl7K Za4T3NfBh4BvoVDo1SISJ+YPEVKCQG5nCurngGrBbs6AnYUBwUFQwwYudww1FfPswq nhvrENi7Lyx5k03xjagWuhMOyH/dgxiFrW1UKH7w= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Thu, 1 Apr 2021 19:13:38 +0900 Message-Id: <20210401101340.160590-7-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210401101340.160590-1-paul.elder@ideasonboard.com> References: <20210401101340.160590-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 6/8] android: camera_device: Add AE mode off to AE available modes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hardware level FULL requires that AE mode off is an available AE mode. Add it. This allows the following CTS test to pass: - android.hardware.camera2.cts.CaptureRequestTest#testAeModeAndLock Signed-off-by: Paul Elder --- src/android/camera_device.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index fc432263..584c3c4a 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -760,7 +760,9 @@ const camera_metadata_t *CameraDevice::getStaticMetadata() aeAvailableAntiBandingModes.data(), aeAvailableAntiBandingModes.size()); + /* \todo FULL requires OFF */ std::vector aeAvailableModes = { + ANDROID_CONTROL_AE_MODE_OFF, ANDROID_CONTROL_AE_MODE_ON, }; staticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_MODES,